Felix>Maybe someone more knowledgeable wants to take a look at it?

TL;DR:  "windows" build host is configured that it prefers to have LF line
separators in text files (there's core.autocrlf=input configured for some
reason).

That setting was activated in
https://issues.apache.org/jira/browse/INFRA-18383 (25 May 2019) which is
just plain wrong.

Git adheres to that configuration and checks out text files as LF
Then Checkstyle runs NewlineAtEndOfFile which recognizes that
platform==Windows, so the check expects  CRLF.

There are at least two ways to deal with that:
A) Ask INFRA to configure core.autocrlf=true for Windows machine (which is
typically recommended for Windows)

B) Ask NewlineAtEndOfFile to support both CRLF / LF end of lines at the
same time. In other words,
it would make sense if NewlineAtEndOfFile could tolerate both LF/CRLF with
no dependence on the current platform.
Currently the check can be configured with a single style of line ending
only.

Vladimir

Reply via email to