Felix>Updated to 8.22. checkstyle is working again.

Nice.

Felix>We still have three tests failing. At least one is because of line
endings:

We have at least two approaches then:

a) Wait for "https://issues.apache.org/jira/browse/INFRA-18763 to make
Windows build hosts to use autocrlf=true"
b) Update the test code so it tolerates the setting of
"core.autocrlf=input" (== LF files in Windows).

Note: the issue is not very Git-specific.
For instance, if someone downloads apache-jmeter-*-source.tgz  archive
under Windows, then it would result in exactly the same failure.

In other words, current
test 
org.apache.jmeter.protocol.jms.sampler.render.ObjectMessageRendererTest#getValueFromFile_withDefaultEncodingAndProlog
expects platform-specific line endings. However it is probably better to
just normalize CRLF to LF before comparison, so the test would tolerate
both styles of the etalon file.

What do you think?

Vladimir

Reply via email to