I can start the release process for 5.4.1 today?

On 09/01/2021 22:04, Felix Schumacher wrote:
Am 09.01.21 um 17:45 schrieb Philippe Mouawad:
Hello Felix,
My answers inline below.

Regards

On Sat, Jan 9, 2021 at 4:28 PM Felix Schumacher
<felix.schumac...@internetallee.de
<mailto:felix.schumac...@internetallee.de>> wrote:


     Am 09.01.21 um 15:28 schrieb Philippe Mouawad:
     Hello,
     First best wishes for 2021 for all the team, I hope you're all
     doing fine !

     Second, I think we should release a 5.4.1 now.
     On my side I've been testing it for few days on Mac OSX and I
     also made some tests on Windows, my colleague did it on Linux.

     The last bug on JTree due to Darklaf
     (https://github.com/weisJ/darklaf/issues/228) was already there
     in 5.3 and it's not that problematic.

     WDYT ?
     I would like to hear your opinion on the bugs 65053 and 65034.

     Bug 65053 is about downgrading JSONPath to 2.4.0 due to a bug with
     regex parsing. I think we could go back to 2.4.0 without loosing
     too much.

Ok by me, sounds acceptable.

     Bug 65034 is about an old bug(?) in handling reading of
     binarytcpclient when no EOM is set. Those requests will always
     fail (at least in my tests). I think we should change the
     behaviour for the case when no EOM is given to not fail on
     SocketTimeoutException.


I looked at your patch, it looks good to me. Thanks
Both committed.

Felix

     Apart from that, I am in favour of releasing soon (or even now :) )

     Felix

     Regards
     Philippe

     On Fri, Dec 11, 2020 at 12:27 PM Felix Schumacher
     <felix.schumac...@internetallee.de
     <mailto:felix.schumac...@internetallee.de>> wrote:



         Am 11. Dezember 2020 12:16:09 MEZ schrieb Philippe Mouawad
         <philippe.moua...@gmail.com <mailto:philippe.moua...@gmail.com>>:
         >On Fri, Dec 11, 2020 at 12:09 PM Felix Schumacher <
         >felix.schumac...@internetallee.de
         <mailto:felix.schumac...@internetallee.de>> wrote:
         >
         >>
         >>
         >> Am 11. Dezember 2020 11:45:22 MEZ schrieb Philippe Mouawad <
         >> philippe.moua...@gmail.com
         <mailto:philippe.moua...@gmail.com>>:
         >> >Hello,
         >> >What is the level of UI test done after Darklaf upgrade ?
         >>
         >> Which level do you want to achieve?
         >>
         >> I have opened, saved an edited some simple test plans
         while working
         >on the
         >> recruiting issues. Nothing fancy. No problems seen on
         Ubuntu with
         >Darklaf
         >> (light intellij theme), that I have noticed.
         >>
         >
         >Has somebody done Windows 7 and 10 tests ?
         >This is where I saw most of the bugs.
         >I'll try to do that ,but for now I didn't find time to do it
         yet.

         I haven't tested yet on windows, but had planned it for the rc.

         >
         >I didn't yet have time to test on Mac OS.

         I don't have that os :)

         >
         >>
         >> >
         >> >Looks a bit too early for me.
         >>
         >> How long should we calculate?
         >>
         >
         >Just when we complete a minimum of tests on Mac and Windows,
         what do
         >you
         >think ?

         I thought, that those tests could be done on the rc, but if
         you want to have a bit more than the minimal testing that has
         been performed by the reporters of the last issues (all
         windows based I believe), then we should wait a bit more and
         test actively on windows.

         Give us a shout, when you feel more comfortable with the
         level of testing. I have no real pressure on this, Linux
         seems to work great ;) in the mean time I will try to test on
         windows, too.

         Regards
          Felix

         >
         >>
         >> Regards
         >>  Felix
         >>
         >>
         >> >
         >> >Thanks
         >> >
         >> >On Fri, Dec 11, 2020 at 10:58 AM Milamber
         <milam...@apache.org <mailto:milam...@apache.org>>
         >wrote:
         >> >
         >> >>
         >> >> I can release version 5.4.1. Now?
         >> >>
         >> >> On 10/12/2020 21:17, Felix Schumacher wrote:
         >> >> > Hi all,
         >> >> >
         >> >> > I think, we have waited long enough, to give people
         time for
         >> >feedback on
         >> >> > the last release.
         >> >> >
         >> >> > Let's do another release. Who would like to act as RM?
         >> >> >
         >> >> > Regards
         >> >> >
         >> >> >   Felix
         >> >> >
         >> >> > PS. I will test the next RC with Windows
         >> >> >
         >> >> > Am 07.12.20 um 16:06 schrieb Felix Schumacher:
         >> >> >> Am 07.12.20 um 13:58 schrieb Philippe Mouawad:
         >> >> >>> Hello,
         >> >> >>> It looks like we may need to release a 5.4.1 due to
         some
         >> >regressions
         >> >> and
         >> >> >>> issues with Darklaf.
         >> >> >> Yes, it certainly looks like a soon next release. I
         would like
         >to
         >> >wait a
         >> >> >> few days, to see, if more problems get reported (not
         weeks,
         >> >though).
         >> >> >>
         >> >> >>
         >> >> >>> Regarding Darklaf, we are having constantly since
         it was
         >> >introduced
         >> >> issues
         >> >> >>> with it on different platforms. Jannis is very
         reactive to fix
         >> >those
         >> >> issues
         >> >> >>> which is great.
         >> >> >>>
         >> >> >>> But the issues are very impacting in terms of UI
         experience
         >(at
         >> >least
         >> >> the
         >> >> >>> ones I faced in the past) and we are still not stable.
         >> >> >>>
         >> >> >>> How can we do to make our releases more robust ?
         >> >> >>> It looks like our automated test don't detect them.
         And the
         >> >manual
         >> >> tests me
         >> >> >>> wake as part of our release process neither.
         >> >> >>> I personally use JMeter mainly on MacOSX, only
         sometimes on
         >> >Windows 10.
         >> >> >>>
         >> >> >>> I faced many issues on Windows as I had to use it
         for one
         >> >customer,
         >> >> this is
         >> >> >>> how I reported them.
         >> >> >> That's what I thought, too. I think we need more
         automated
         >tests
         >> >for the
         >> >> >> GUI part, as one regression showed up on saving test
         plans on a
         >> >Windows
         >> >> OS.
         >> >> >>
         >> >> >> @All, do you have experience testing a (Swing) GUI?
         What would
         >be
         >> >a good
         >> >> >> way to introduce this, for at least some basic stuff
         like
         >opening
         >> >a test
         >> >> >> plan, creating one through the UI, saving it.
         >> >> >>
         >> >> >>> @Dev team, what are the OSes you use ?
         >> >> >> Linux (Ubuntu really)
         >> >> >>
         >> >> >>
         >> >> >>> If we are not able to improve this, maybe we should
         switch
         >back
         >> >to
         >> >> System
         >> >> >>> LAFs.
         >> >> >> That is always possible.
         >> >> >>
         >> >> >> Regards
         >> >> >>
         >> >> >>   Felix
         >> >> >>
         >> >> >>> Regards
         >> >>
         >> >>
         >>



     --
     Cordialement.
     Philippe Mouawad.



--
Cordialement.
Philippe Mouawad.



Reply via email to