wkurniawan07 commented on code in PR #708:
URL: https://github.com/apache/jmeter/pull/708#discussion_r848144853
##########
src/core/src/main/java/org/apache/jmeter/gui/action/HtmlReportGenerator.java:
##########
@@ -83,7 +84,7 @@ public List<String> run() {
LOGGER.debug("Running report generation");
resultCode = sc.run(generationCommand);
if (resultCode != 0) {
- errorMessageList.add(commandExecutionOutput.toString());
+
errorMessageList.add(commandExecutionOutput.toString(StandardCharsets.UTF_8.name()));
Review Comment:
Taking an idealistic point-of-view, I would agree with you. However, you're
the one who knows the possible complications and what-nots if we do use UTF-8
(or anything else, for that matter) here right now. So should this stay as
UTF-8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
