FSchumacher commented on PR #708: URL: https://github.com/apache/jmeter/pull/708#issuecomment-1097725078
> Not that I disagree about it, but this catch block here is unavoidable. It is thrown because `w.toString(CHARSET)` is called from within `throw new ReadException(...)`. This is avoidable only if the result of `w.toString(CHARSET)` is accessible within the catch block without calling the said method, but making it happen requires even more non-trivial changes on this method. That is, why I gave the size of w as an example, only :) That should not throw an UnsupportedEncodingException. But, yes, it will get more complex. Another possibility would be to extract the char conversion into a method, which could discard(catch) the exception and return a meaningful error message instead of the encoded message w. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
