vlsi commented on code in PR #5761:
URL: https://github.com/apache/jmeter/pull/5761#discussion_r1183761662
##########
src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java:
##########
@@ -82,12 +85,23 @@ public void prepareForPreCompile()
}
/**
- * Fetches the functional mode property
- *
+ * Fetches the functional mode property<br>
+ * Could be change for no-GUI test with jmeter property: {@code
PROP_FUNCTIONAL_MODE}
* @return functional mode
*/
public boolean isFunctionalMode() {
- return getPropertyAsBoolean(FUNCTIONAL_MODE);
+ boolean functionalModeDefault = getPropertyAsBoolean(FUNCTIONAL_MODE);
+ log.debug("functionalModeDefault=" + functionalModeDefault);
+ boolean functionalModeReturn = functionalModeDefault;
+ if (isNonGui()) {
Review Comment:
Why the override is for `non-gui-mode` only?
I think we should not add mode-dependent settings as it would be hard to
tell why the behaviour is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
