jgaalen commented on code in PR #6256:
URL: https://github.com/apache/jmeter/pull/6256#discussion_r1538189489
##########
src/components/src/main/java/org/apache/jmeter/extractor/gui/RegexExtractorGui.java:
##########
@@ -208,6 +214,8 @@ private JPanel makeParameterPanel() {
templateField = new
JLabeledTextField(JMeterUtils.getResString("template_field")); //$NON-NLS-1$
refNameField = new
JLabeledTextField(JMeterUtils.getResString("ref_name_field")); //$NON-NLS-1$
matchNumberField = new
JLabeledTextField(JMeterUtils.getResString("match_num_field")); //$NON-NLS-1$
+ failResultField = new
JLabel(JMeterUtils.getResString("fail_if_not_matched_field"));
+ failResult = new JCheckBox();
Review Comment:
I see, although the JEditableCheckbox is a nice feature to paramaterize
scripts, I don't think it's a good usecase on this specific checkbox. I don't
see a reason to parameterize a specific regex extractor. The other checkboxes
on the Regex Extractor aren't an editable checkbox as well.
I can give it a try tho, If it doesn't help, it doesn't hurt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
