jgaalen commented on code in PR #6256: URL: https://github.com/apache/jmeter/pull/6256#discussion_r1538211160
########## src/dist-check/src/test/java/org/apache/jmeter/junit/JMeterTest.java: ########## @@ -382,6 +382,7 @@ public void GUIComponents2(GuiComponentHolder componentHolder) throws Exception IGNORED_PROPERTIES.add(LoopControllerSchema.INSTANCE.getContinueForever()); IGNORED_PROPERTIES.add(RegexExtractorSchema.INSTANCE.getMatchTarget()); IGNORED_PROPERTIES.add(RegexExtractorSchema.INSTANCE.getDefaultIsEmpty()); + IGNORED_PROPERTIES.add(RegexExtractorSchema.INSTANCE.getFailIfNotFound()); Review Comment: I have no idea, if I don't add this line the build fails on the tests: ``` org.opentest4j.AssertionFailedError: GUI element class org.apache.jmeter.extractor.gui.RegexExtractorGui org.apache.jmeter.extractor.gui.RegexExtractorGui[${test_TestElement.name},0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=javax.swing.border.EmptyBorder@10142fa,flags=9,maximumSize=,minimumSize=,preferredSize=] be able to pass all the properties to a different TestElement ==> expected: <org.apache.jmeter.extractor.RegexExtractor::class { props { it[name] = "\${test_TestElement.name}" it[guiClass] = "org.apache.jmeter.extractor.gui.RegexExtractorGui" it[referenceName] = "\${test_RegexExtractor.refname}" it[regularExpression] = "\${test_RegexExtractor.regex}" it[template] = "\${test_RegexExtractor.template}" it[default] = "\${test_RegexExtractor.default}" it[matchNumber] = "\${test_RegexExtractor.match_number}" it[failIfNotFound] = "\${test_RegexExtractor.fail_if_not_found}" it[comments] = "\${test_TestPlan.comments}" } } > but was: <org.apache.jmeter.extractor.RegexExtractor::class { props { it[name] = "\${test_TestElement.name}" it[guiClass] = "org.apache.jmeter.extractor.gui.RegexExtractorGui" it[comments] = "\${test_TestPlan.comments}" it[referenceName] = "\${test_RegexExtractor.refname}" it[regularExpression] = "\${test_RegexExtractor.regex}" it[template] = "\${test_RegexExtractor.template}" it[default] = "\${test_RegexExtractor.default}" it[matchNumber] = "\${test_RegexExtractor.match_number}" it[failIfNotFound] = false } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org