LuisOsv commented on code in PR #6453:
URL: https://github.com/apache/jmeter/pull/6453#discussion_r2096534340
##########
src/core/src/main/java/org/apache/jmeter/util/JsseSSLManager.java:
##########
@@ -213,14 +213,15 @@ private SSLContext createContext() throws
GeneralSecurityException {
JmeterKeyStore keys = this.getKeyStore();
managerFactory.init(null, defaultpw == null ? new char[]{} :
defaultpw.toCharArray());
KeyManager[] managers = managerFactory.getKeyManagers();
- KeyManager[] newManagers = new KeyManager[managers.length];
+ int managersCount = managers.length;
+ KeyManager[] newManagers = new KeyManager[managersCount];
if (log.isDebugEnabled()) {
log.debug("JmeterKeyStore type: {}", keys.getClass());
}
// Now wrap the default managers with our key manager
- for (int i = 0; i < managers.length; i++) {
+ for (int i = 0; i < managersCount; i++) {
Review Comment:
Hi @vlsi agreed, but the new version will still use index since there is
insertion on the array given the index. Are you ok with this change?
Example:
```
int indexManager = 0;
for (KeyManager manager : managers) {
if (manager instanceof X509KeyManager) {
newManagers[indexManager] = new
WrappedX509KeyManager((X509KeyManager) manager, keys);
} else {
newManagers[indexManager] = manager;
}
indexManager++;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
