LuisOsv commented on code in PR #6453:
URL: https://github.com/apache/jmeter/pull/6453#discussion_r2219450225
##########
src/core/src/main/java/org/apache/jmeter/config/gui/ArgumentsPanel.java:
##########
@@ -441,10 +441,10 @@ private void moveDown() {
// or the selected rows will be unselected
int[] rowsSelected = table.getSelectedRows();
GuiUtils.stopTableEditing(table);
-
- if (rowsSelected.length > 0 && rowsSelected[rowsSelected.length - 1] <
table.getRowCount() - 1) {
+ int selectedRowsCount = rowsSelected.length;
+ if (selectedRowsCount > 0 && rowsSelected[selectedRowsCount - 1] <
table.getRowCount() - 1) {
table.clearSelection();
- for (int i = rowsSelected.length - 1; i >= 0; i--) {
+ for (int i = selectedRowsCount - 1; i >= 0; i--) {
Review Comment:
hi @vlsi I think the change improves readability and maintainability. and
It does not affect functionality. Are you still agree with reverting changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
