[
https://issues.apache.org/jira/browse/JOHNZON-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936516#comment-16936516
]
Romain Manni-Bucau commented on JOHNZON-272:
--------------------------------------------
[~mkarg] well, any build must be as deterministic as possible so not OS
dependent, therefore PR 50 is a regression on that aspect. Also the plugin
works well on windows, maybe not as you expect which is different ;). So two
points for me:
# do we want to make the EOL configurable in the plugin (but still
deterministic and OS independent, this is key)? I don't care much, I am fine
with or without it.
# if your clone changes pushed files then you are not deterministic so you
have an issue which is not project related so I still think it can be worth
updating the doc for portability. Take this simple case: if a test is written
in a deterministic way (most of our tests are) and you change inputs due to a
local setup (making the sources OS dependent whereas the only source of truth
is the git server) then failures are not a bug of the project but a bug of you
local setup which diff-ed the actual sources IMHO.
> Fails to build Johnzon :: Maven Plugin
> --------------------------------------
>
> Key: JOHNZON-272
> URL: https://issues.apache.org/jira/browse/JOHNZON-272
> Project: Johnzon
> Issue Type: Bug
> Affects Versions: 1.2.0
> Environment: {{$ mvn -version}}
> {{Apache Maven 3.6.1 }}(d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> {{Maven home: C:\Program Files\apache-maven-3.6.1}}
> {{Java version: 1.8.0_181, vendor: Azul Systems, Inc., runtime: C:\Program
> Files\zulu8.31.0.1-jdk8.0.181-win_x64\jre}}
> {{Default locale: de_DE, platform encoding: Cp1252}}
> {{OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"}}
> Reporter: Markus Karg
> Priority: Blocker
> Fix For: 1.2.1
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{$ git clone https://github.com/apache/johnzon.git}}
> {{$ cd johnzon}}
>
> {{$mvn clean install}}
> {{...}}
> {{[INFO] Running org.apache.johnzon.maven.plugin.ExampleToModelMojoTest}}
> {{[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.172 s <<< FAILURE! - in
> org.apache.johnzon.maven.plugin.ExampleToModelMojoTest}}
> {{[ERROR] generate(org.apache.johnzon.maven.plugin.ExampleToModelMojoTest)
> Time elapsed: 0.125 s <<< FAILURE!}}
> {{org.junit.ComparisonFailure:}}
> {{expected:</*[}}
> {{ * Licensed to the Apache Software Foundation (ASF) under one}}
> {{...}}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
