[
https://issues.apache.org/jira/browse/JOHNZON-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936523#comment-16936523
]
Markus Karg commented on JOHNZON-272:
-------------------------------------
[~romain.manni-bucau] (1) Actually the build _is_ deterministic using PR 50,
but the outcome on Linux simply _must_ be different than on Windows. This has
+nothing+ to do with _my_ expectation, it is simply *wrong* on Windows to
create single-line source code. So no, making the EOL configurable is the worst
idea at all, as it would just create confusion: Why should somebody want to
change the EOL? It is *the JRE*'s job to adapt OS-neutral behavior to the OS
specific behavior, and PR 50 powers exactly that. PR 50 as-is is the sole
*correct* solution, even if you might have a different opinion (I assume
because you are not a Windows guy). Regarding (2) maybe my English is not good
enough but I don't understand completely what you mean. Can you rephrase that
please?
> Fails to build Johnzon :: Maven Plugin
> --------------------------------------
>
> Key: JOHNZON-272
> URL: https://issues.apache.org/jira/browse/JOHNZON-272
> Project: Johnzon
> Issue Type: Bug
> Affects Versions: 1.2.0
> Environment: {{$ mvn -version}}
> {{Apache Maven 3.6.1 }}(d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> {{Maven home: C:\Program Files\apache-maven-3.6.1}}
> {{Java version: 1.8.0_181, vendor: Azul Systems, Inc., runtime: C:\Program
> Files\zulu8.31.0.1-jdk8.0.181-win_x64\jre}}
> {{Default locale: de_DE, platform encoding: Cp1252}}
> {{OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"}}
> Reporter: Markus Karg
> Priority: Blocker
> Fix For: 1.2.1
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{$ git clone https://github.com/apache/johnzon.git}}
> {{$ cd johnzon}}
>
> {{$mvn clean install}}
> {{...}}
> {{[INFO] Running org.apache.johnzon.maven.plugin.ExampleToModelMojoTest}}
> {{[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.172 s <<< FAILURE! - in
> org.apache.johnzon.maven.plugin.ExampleToModelMojoTest}}
> {{[ERROR] generate(org.apache.johnzon.maven.plugin.ExampleToModelMojoTest)
> Time elapsed: 0.125 s <<< FAILURE!}}
> {{org.junit.ComparisonFailure:}}
> {{expected:</*[}}
> {{ * Licensed to the Apache Software Foundation (ASF) under one}}
> {{...}}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
