reta edited a comment on pull request #73:
URL: https://github.com/apache/johnzon/pull/73#issuecomment-761689210


   @rmannibucau comments addressed, the only regression I have seen so far 
across the test suite is this guy:
   ```
       @Test
       public void dontStackOverFlowUsingFieldAccess() {
           final Throwable oopsImVicous = new Exception("circular");
           oopsImVicous.getStackTrace(); // fill it
           oopsImVicous.initCause(new IllegalArgumentException(oopsImVicous));
           final String serialized = new 
MapperBuilder().setAccessModeName("field").build().writeObjectAsString(oopsImVicous);
           assertTrue(serialized.contains("\"detailMessage\":\"circular\""));
           assertTrue(serialized.contains("\"stackTrace\":[{"));
       }
   ```
   Essentially, with `field` access mode, none of the `Exception` fields are 
accessible and `serialized ` is effectively empty. Personally, I don't think 
this is a concern since with `method` access level things work fine.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to