reta edited a comment on pull request #73:
URL: https://github.com/apache/johnzon/pull/73#issuecomment-761884192


   @rmannibucau Yes, I do have a test but I am very surprised with your 
outcomes, I saw a number (but not many) of test failures. Just to double check, 
you used latest JDK-16 EA build, right? (the JEP in question was integrated ~ 
month ago). Could you also try JDK17-ea? Thanks.
   
   Edit: Just a number of different failures in `ReadPrimitiveTest` & 
`CircularExceptionTest` fe:
   
   ```
   java.lang.reflect.InaccessibleObjectException: Unable to make field private 
final char java.lang.Character.value accessible: module java.base does not 
"opens java.lang" to unnamed module @33833882
        at 
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:357)
        at 
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
        at 
java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:177)
        at java.base/java.lang.reflect.Field.setAccessible(Field.java:171)
        at 
org.apache.johnzon.mapper.access.FieldAccessMode$FieldDecoratedType.<init>(FieldAccessMode.java:105)
        at 
org.apache.johnzon.mapper.access.FieldAccessMode$FieldReader.<init>(FieldAccessMode.java:169)
        at 
org.apache.johnzon.mapper.access.FieldAccessMode.doFindReaders(FieldAccessMode.java:49)
        at 
org.apache.johnzon.mapper.access.BaseAccessMode.findReaders(BaseAccessMode.java:82)
        at 
org.apache.johnzon.mapper.access.FieldAndMethodAccessMode.doFindReaders(FieldAndMethodAccessMode.java:68)
        at 
org.apache.johnzon.mapper.access.BaseAccessMode.findReaders(BaseAccessMode.java:82)
        at 
org.apache.johnzon.mapper.Mappings.createClassMapping(Mappings.java:475)
           ...
        at org.apache.johnzon.mapper.Mapper.readObject(Mapper.java:295)
        at 
org.apache.johnzon.mapper.ReadPrimitiveTest.testCharacter(ReadPrimitiveTest.java:48)
   ```
   
   ```
   java.lang.reflect.InaccessibleObjectException: Unable to make field private 
java.lang.Throwable java.lang.Throwable.cause accessible: module java.base does 
not "opens java.lang" to unnamed module @33833882
        at 
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:357)
        at 
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
        at 
java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:177)
        at java.base/java.lang.reflect.Field.setAccessible(Field.java:171)
        at 
org.apache.johnzon.mapper.access.FieldAccessMode$FieldDecoratedType.<init>(FieldAccessMode.java:105)
        at 
org.apache.johnzon.mapper.access.FieldAccessMode$FieldReader.<init>(FieldAccessMode.java:169)
        at 
org.apache.johnzon.mapper.access.FieldAccessMode.doFindReaders(FieldAccessMode.java:49)
        at 
org.apache.johnzon.mapper.access.BaseAccessMode.findReaders(BaseAccessMode.java:82)
        at 
org.apache.johnzon.mapper.Mappings.createClassMapping(Mappings.java:475)
        at 
org.apache.johnzon.mapper.Mappings.doFindOrCreateClassMapping(Mappings.java:437)
           ...
        at org.apache.johnzon.mapper.Mapper.writeObjectAsString(Mapper.java:252)
        at 
org.apache.johnzon.mapper.CircularExceptionTest.dontStackOverFlow(CircularExceptionTest.java:31)
   ```
   I will shortly extract the test for `ArrayList` as well


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to