Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131505
--- Diff: src/main/java/org/apache/joshua/decoder/chart_parser/Chart.java
---
@@ -683,8 +681,8 @@ private int addUnaryNodes(Grammar[] grammars, int i,
int j) {
ArrayList<HGNode> queue = new
ArrayList<HGNode>(chartBin.getSortedNodes());
HashSet<Integer> seen_lhs = new HashSet<Integer>();
- if (logger.isLoggable(Level.FINEST))
- logger.finest("Adding unary to [" + i + ", " + j + "]");
+ if (LOG.isDebugEnabled())
--- End diff --
I think we're ok to just call Log.debug in this case without worrying about
any perf issues. We can probably skip the isDebugEnabled() check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
