Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131583
--- Diff: src/main/java/org/apache/joshua/decoder/ff/lm/ArpaFile.java ---
@@ -180,21 +177,21 @@ public Vocabulary getVocab() {
@SuppressWarnings("unused")
public int size() {
- logger.fine("Counting n-grams in ARPA file");
+ LOG.debug("Counting n-grams in ARPA file");
int count=0;
for (ArpaNgram ngram : this) {
count++;
}
- logger.fine("Done counting n-grams in ARPA file");
+ LOG.debug("Done counting n-grams in ARPA file");
return count;
}
public int getOrder() throws FileNotFoundException {
Pattern pattern = Pattern.compile("^ngram (\\d+)=\\d+$");
- if (logger.isLoggable(Level.FINEST)) logger.finest("Pattern is " +
pattern.toString());
+ if (LOG.isDebugEnabled()) LOG.debug("Pattern is {}",
pattern.toString());
--- End diff --
I think we can remove the isDebugEnabled check here. We can also remove
the toString()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
