Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-joshua/pull/36#discussion_r73449163
  
    --- Diff: src/main/java/org/apache/joshua/server/ServerThread.java ---
    @@ -225,15 +225,18 @@ private void handleMetadata(String meta, JSONMessage 
message) {
           String source = argTokens[1];
           String target = argTokens[2];
           String featureStr = "";
    +      String alignmentStr = "";
           if (argTokens.length > 3) 
             featureStr = argTokens[3];
    -          
    +      if (argTokens.length > 4)
    +        alignmentStr = " ||| " + argTokens[4];
    --- End diff --
    
    What is this `alignmentStr` argument for ? Wonder if we could add test for 
this new argument


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to