On 7/23/07, Nicolas Modrzyk <[EMAIL PROTECTED]> wrote:
Hi devs, I have submitted patches for the following jira issues: http://jira.codehaus.org/browse/JRUBY-1230 http://jira.codehaus.org/browse/JRUBY-1228 http://jira.codehaus.org/browse/JRUBY-1108 Would it be possible to review and commit them ?
Hi, thanks for the patches, and apologies for letting them go for a while. Folks' summer schedules have reduced the amount of time we're able to spend looking at JIRAs. The patches look fine, and tests pass, so I committed them. A couple of minor nitpicks, hope you don't mind: - Please use spaces instead of tabs. (I know we don't always follow this ourselves, but that doesn't mean I can't ask you to :) - If it's at all possible to work up test cases, please do so, so we can ensure the code doesn't regress. I know IO is a particularly thorny topic to try to write effective unit tests for, but see if you can anyway. Thanks again, /Nick
