Hi Nick,
Thanks for submitting the patches!
I've also submitted (before) patches for the following ones, and I
think there should be a test case for most of them (if not all of them)
http://jira.codehaus.org/browse/JRUBY-1207
http://jira.codehaus.org/browse/JRUBY-1140
http://jira.codehaus.org/browse/JRUBY-1215
http://jira.codehaus.org/browse/JRUBY-1214
Not sure about the tab thing, since I force tabs to spaces all the
time. Maybe when the patch is created ?
I would take special care in the future.
Regards,
Niko
On Jul 25, 2007, at 10:38 PM, Nick Sieger wrote:
On 7/23/07, Nicolas Modrzyk <[EMAIL PROTECTED]> wrote:
Hi devs,
I have submitted patches for the following jira issues:
http://jira.codehaus.org/browse/JRUBY-1230
http://jira.codehaus.org/browse/JRUBY-1228
http://jira.codehaus.org/browse/JRUBY-1108
Would it be possible to review and commit them ?
Hi, thanks for the patches, and apologies for letting them go for a
while. Folks' summer schedules have reduced the amount of time
we're able to spend looking at JIRAs.
The patches look fine, and tests pass, so I committed them. A
couple of minor nitpicks, hope you don't mind:
- Please use spaces instead of tabs. (I know we don't always
follow this ourselves, but that doesn't mean I can't ask you to :)
- If it's at all possible to work up test cases, please do so, so
we can ensure the code doesn't regress. I know IO is a
particularly thorny topic to try to write effective unit tests for,
but see if you can anyway.
Thanks again,
/Nick
