[
https://issues.apache.org/jira/browse/JSPWIKI-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111150#comment-14111150
]
Harry Metske commented on JSPWIKI-856:
--------------------------------------
I personally do not bother about the HitCountPlugin, it is not a core plugin
(PageViewPlugin is in core, but works slightly different).
Anyway, patch looks good to me, it would be even better if you could add a
couple of unit tests or expand the existing tests for the two providers (to
prevent your work from being broken in the future).
thanks for the work so far !
regards,
Harry
> Enhance FileSystemProvider to be able to save page attributes as properties
> ---------------------------------------------------------------------------
>
> Key: JSPWIKI-856
> URL: https://issues.apache.org/jira/browse/JSPWIKI-856
> Project: JSPWiki
> Issue Type: New Feature
> Components: Core & storage
> Affects Versions: 2.10.1
> Reporter: David Vittor
> Labels: provider
> Attachments: AbstractFileProvider.java, AbstractFileProvider.java,
> FileSystemProvider.java, FileSystemProvider.java,
> VersioningFileProvider.java, VersioningFileProvider.java, WikiPage.java,
> providers.patch, providers.patch
>
>
> *Requirements:*
> * 1. Plugins and other code should be able to store some page "attributes"
> into the "properties" of a page, just as author and changenote currently are.
> * 2. This should work for both FileSystemProvider and VersioningFileProvider
> and any future JDBCProviders or EncryptionProviders
> * 3. The properties added should be dynamic, e.g. all properties starting
> with "db:" like "db:likes", or "db:hitcount"
> ** 3.1. A "protected" addCustomProperties() method should be done added
> * 4. The property names and property values should be validated
> ** 4.1. A "protected" validateCustomProperties() method should be done added
> ** 4.2 e.g. only contain ascii characters
> ** 4.3 Max property key length
> ** 4.4 Max property value length
> ** 4.5 Max number of properties
--
This message was sent by Atlassian JIRA
(v6.2#6252)
