[
https://issues.apache.org/jira/browse/JSPWIKI-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137548#comment-14137548
]
Harry Metske commented on JSPWIKI-856:
--------------------------------------
Looks good to me, so +1 on this patch, anyone else opinions ?
I would also like to see something in ini/jspwiki.properties describing the 3
new props:
public static final String PROP_CUSTOMPROP_MAXLIMIT =
"custom.property.max.allowed";
public static final String PROP_CUSTOMPROP_MAXKEYLENGTH =
"custom.property.key.length";
public static final String PROP_CUSTOMPROP_MAXVALLENGTH =
"custom.property.value.length";
Having said that, maybe it would be less confusing to rename these properties
to pageproperties :
public static final String PROP_CUSTOMPROP_MAXLIMIT =
"custom.pageproperty.max.allowed";
public static final String PROP_CUSTOMPROP_MAXKEYLENGTH =
"custom.pageproperty.key.length";
public static final String PROP_CUSTOMPROP_MAXVALLENGTH =
"custom.pageproperty.value.length";
WDYT ?
> Enhance FileSystemProvider to be able to save page attributes as properties
> ---------------------------------------------------------------------------
>
> Key: JSPWIKI-856
> URL: https://issues.apache.org/jira/browse/JSPWIKI-856
> Project: JSPWiki
> Issue Type: New Feature
> Components: Core & storage
> Affects Versions: 2.10.1
> Reporter: David Vittor
> Priority: Minor
> Labels: provider
> Attachments: AbstractFileProvider.java, AbstractFileProvider.java,
> FileSystemProvider.java, FileSystemProvider.java,
> VersioningFileProvider.java, VersioningFileProvider.java, WikiPage.java,
> providers.patch, providers.patch, providers.patch
>
>
> *Requirements:*
> * 1. Plugins and other code should be able to store some page "attributes"
> into the "properties" of a page, just as author and changenote currently are.
> * 2. This should work for both FileSystemProvider and VersioningFileProvider
> and any future JDBCProviders or EncryptionProviders
> * 3. The properties added should be dynamic, e.g. all properties starting
> with "@" like "@likes", or "@hitcount"
> ** 3.1. A "protected" addCustomProperties() method should be done added
> * 4. The property names and property values should be validated
> ** 4.1. A "protected" validateCustomProperties() method should be done added
> ** 4.2 e.g. only contain ascii characters
> ** 4.3 Max property key length
> ** 4.4 Max property value length
> ** 4.5 Max number of properties
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
