Hi Christian, Glad to hear you liked my "How To Write A Plugin" page :)
Yes the log4j part I added in there for debugging and ensuring the code in the plugin used the log4j framework, but I think Juan is right that it probably does not need to be bundled into the plugin. This page will have to be updated. I'm very excited by your plugin, as I'm currently working on something similar. I'm building an Javascript/AJAX plugin for storing, adding and editing data information (Excel for the cloud). I'll check out your plugin when I return from my holidays in a few weeks. But good on you for writing and sharing it with the community! Cheers, David V On Mon, Mar 21, 2016 at 7:48 AM, cfr Mails 2016 <cfr2...@gmx.net> wrote: > Thanks Harry, I could create my account now. > > Thanks Juan Pablo, for your feedback; I will do as suggested. > Just one remark: > I added the "log4j.properties" file because it was written here: > https://jspwiki-wiki.apache.org/Wiki.jsp?page=HowToWriteAPlugin < > https://jspwiki-wiki.apache.org/Wiki.jsp?page=HowToWriteAPlugin> > The page was an excellent help to implement the Plugin, but in that point > it might have to be updated. > > I will use and test the plugin in this week, then update repository and > wiki. > > best regards > Christian > > > > > Am 20.03.2016 um 21:26 schrieb Harry Metske <harry.met...@gmail.com>: > > > > I re-enabled user registration on the wiki, you should be able to > register > > now. > > > > Regards, > > Harry > > Op 20 mrt. 2016 9:21 p.m. schreef "Juan Pablo Santos RodrÃguez" < > > juanpablo.san...@gmail.com>: > > > >> Hi Christian, > >> > >> thanks for sharing your plugin! > >> > >> - re. packaging additional files, as you're shipping a maven project, > the > >> easiest way to distribute your plugin is to declare the additional jars > as > >> dependecies (as you've done). That way, anyone retrieving your plugin is > >> going to get the additional jars as part of their build > >> > >> - re. adding Table plugin, IMO is ok (Dirk can correct me, as he's the > >> author), but I think at least you should explicitly note it, either in > the > >> code or in the readme.md file.. > >> > >> - re. licenses, AL is fine, but if you are unsure, you can check > >> http://choosealicense.com/ to see which license fits you more > >> > >> - re. jspwiki-wiki.a.o issues, we recently got a huge wave of spam, so > the > >> wiki's policies have been changed in order to not allow indiscriminated > >> edits, or users or groups creation. In the meantime, I'll add a link to > >> https://jspwiki-wiki.apache.org/Wiki.jsp?page=ContributedPlugins > pointing > >> to https://github.com/generatorr/WorksheetPlugin with proper credits. > As > >> for the upload section, it looks like a permissions issue + a bug (you > >> shouldn't see an error page). I'll try to take a look at it this week.. > >> > >> - Finally, re. the code itself, overall it looks ok to me, only 3 small > >> things: > >> * I'd delete the log4j.properties file > >> * add some more tests > >> * on the pom.xml file, remove the use of the copy-dependencies plugin, > the > >> poi dependencies are going to be pushed with your plugin. > >> > >> > >> br, > >> juan pablo > >> > >> On Sun, Mar 20, 2016 at 7:29 PM, cfr Mails 2016 <cfr2...@gmx.net> > wrote: > >> > >>> Hi JSPWiki developers, > >>> > >>> I am working with JSPWiki since a few years now (as a user) and it is > >>> really useful for distributing up-to-date information to the team. > >>> > >>> We are working a lot with Microsoft Office products, and people like > >>> having their data stored in Excel tables. > >>> In order to get this data into JSPWiki, I have been working with the > >>> "Table" plugin. > >>> It works, and looks good, but formatting is a bit time consuming. > >>> > >>> Now I have played around with Apache POI, which is a library to > directly > >>> access Excel Workbooks from Java Code: > >>> The "Worksheet Plugin" extracts the data from from an Excel Workbook, > and > >>> generates a string which then will be parsed by the Table plugin. > >>> > >>> Through this, JSPWiki can have a Excel workbook as Attachment on a > page, > >>> and present its content in an ordinary wiki table. > >>> > >>> Usage: > >>> > >>> [{WorksheetPlugin src='NameOfAttachedExcel.xlsx' sheetName='MyData' }] > >>> > >>> For sure this is just a basic version, which just prints the content of > >>> the cells. > >>> Improvements could be: > >>> - take care of cell formatting, > >>> - support merged cells, > >>> - Caching of the content, so that the excel doesn't need to be parsed > >>> again and again; > >>> - directly create html from the cells instead of using the "Table" > >> plugin, > >>> - support images and diagrams > >>> - etc. > >>> But this first version works. > >>> > >>> There are a few questions: > >>> - the plugin requires a number of additional .jar files (poi.xml and > >>> others). > >>> Can I package these additional jar files together with "my" plugin, so > >>> that the user needs to copy only one .jar file into the WEB-INF/lib > >>> directory? > >>> > >>> - As I didn't want that the user must install the "Table" Plugin > >>> additionally, I have included it's unchanged source code into the new > >>> plugin. > >>> Is it ok to do so? Is there a better approach? > >>> > >>> - under which license should I publish the plugin? > >>> Everybody should be able to use and improve free of charge. JSPWiki is > >>> under Apache Software License 2.0; is this what I want for > >> WorksheetPlugin? > >>> > >>> - I don't have access to the attachments at > >>> https://jspwiki-wiki.apache.org/ <https://jspwiki-wiki.apache.org/>. > The > >>> wiki won't let me create an Account. > >>> How can I get an account here? If the plugin proves useful, should I > >>> create a page in that wiki? > >>> > >>> Sources are here. Please review. This is my first JSPWiki plugin. > Looking > >>> forward to feedback > >>> https://github.com/generatorr/WorksheetPlugin < > >>> https://github.com/generatorr/WorksheetPlugin> > >>> > >>> Download v0.1-alpha: > >>> https://github.com/generatorr/WorksheetPlugin/releases < > >>> https://github.com/generatorr/WorksheetPlugin/releases> > >>> > >>> Thanks! > >>> > >>> Christian > >> > >
