Thanks all. Alex, that sounds useful: could you attach your pac4j code, or a description of it, to JSPWIKI-1315? Jerry, I agree that the JAAS documentation is thin, so I will add the documentation of the container and JAAS set up to that issue, with a reference implementation. For the import and export I will change JSPWIKI-1316 to describe an extension point with one reference importer, and not a fixed set of formats. The installation process is a good point and I will look for an existing issue before opening a new one.
Arturo On Tue, Oct 27, 2026 at 1:26 AM Alex O'Ree <[email protected]> wrote: > I have some copy pasta using pac4j. I'd suggest looking into this. > Implementation wasn't too bad > > On Mon, Oct 26, 2026 at 2:18 PM Arturo Bernal <[email protected]> wrote: > > > > Hi Juergen, > > > > Thanks, that is a fair point, and I agree that we should not write > security > > code that the container already provides. JSPWiki already has > > WebContainerLoginModule for container managed authentication. > > > > I have not tested JSPWiki against container managed OIDC yet, so I do not > > know if it works end to end today. One thing I would check is > JSPWIKI-1176, > > which says that the roles Admin and Authenticated are hard coded, because > > that could get in the way of mapping roles from an external provider. > > > > I will change JSPWIKI-1315 to this: verify and document OIDC through the > > container, and fix what does not work. A login module in JSPWiki itself > > would only be considered if the container is not enough. > > > > Arturo > > > > > > On Mon, Oct 26, 2026 at 7:08 PM Jürgen Weber <[email protected]> wrote: > > > > > Hi, > > > > > > enterprise or security features like OpenID, password security or user > > > management should be left to the application server and Active > > > Directory. > > > > > > E.g. with Wildfly application server OpenID is as easy as auth-method > > > OIDC in web.xml > > > > > > Don't reinvent, don't bloat the wiki, use the power of Jakarta EE. > > > > > > Cheers, > > > Juergen > > > > > > Am Mo., 26. Okt. 2026 um 18:46 Uhr schrieb Arturo Bernal < > > > [email protected]>: > > > > > > > > Hi all, > > > > > > > > Following my earlier mail, three more Jira issues with proposals. As > > > > before, none is implemented and I would like feedback on the > direction > > > > first. > > > > > > > > > > > > 1. JSPWIKI-1315, OpenID Connect login. Authentication is JAAS > based > > > > with the login modules in org.apache.wiki.auth.login, so single > > > sign-on > > > > depends on what the container offers. The proposal is an optional > > > module > > > > that works next to the existing ones. The open points are which > OIDC > > > > library is acceptable and how provider groups map to JSPWiki > groups > > > and > > > > roles. JSPWIKI-861 and JSPWIKI-94 are related but old and > narrower. > > > > 2. JSPWIKI-1316, importing from other wikis and exporting. I > found > > > no > > > > import tool and no export to static HTML, PDF or Markdown. The > > > proposal > > > > covers a Markdown tree, MediaWiki and Confluence as import > sources, > > > and > > > > static HTML or Markdown as export formats. The open question is > which > > > > sources matter most. > > > > 3. JSPWIKI-1317, accessibility of the default template and > support > > > for > > > > the browser colour scheme preference. The template is already > > > responsive. > > > > The issue proposes an audit with an automated checker plus a > manual > > > > keyboard and screen reader pass, fixes for what it finds, and a > dark > > > > variant of the default skin. > > > > > > > > > > > > Comments on any of them are welcome, including "not worth it". > > > > > > > > Thanks, > > > > > > > > Arturo > > > >
