[
https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505934#comment-13505934
]
Neha Narkhede commented on KAFKA-622:
-------------------------------------
v3 looks much better and almost ready for check in. Few minor cleanup comments -
9. Minor naming convention suggestion - Probably better to rename
ClientIdTopicPartition to ClientIdAndPartition or ClientIdAndTopicPartition
10. ProducerPool Minor documentation nitpick - The API docs for
createSyncProducer doesn't match the commenting style for documenting APIs. We
use C style comments while this patch has added C++ style comments.
11. SimpleConsumerPerformance - Remove unused import
FetchRequestAndResponseStats
12. BrokerPartitionInfo - Not introduced by your patch, but will be good to
fix. Typo in the name of the param. Change it to topics instead of topic
13.1 Producer - Again not introduced by your patch, just happened to notice it
right now. Typo in the name of the param in send API docs. It says producerData
now but should be messages
13.2 Minor nitpick - Rest of the metrics classes have name as their constructor
argument, except ProducerTopicMetrics which says tuple and its not a tuple.
14. SyncProducerConfig - Elsewhere, we don't use camel case for config names.
Probably best to change it to clientid like in ConsumerConfig
15. What happened to Topic.scala ?
7. For now, it seems that the messages rate, both per topic and global should
suffice. We can, however, think about how/if the aggregation metrics for fetch
response rate and size makes sense at the ZookeeperConsumerConnector level. But
I d
on't think we should hold up this patch for it. Please can you file a JIRA to
track that ?
> Create mbeans per client
> -------------------------
>
> Key: KAFKA-622
> URL: https://issues.apache.org/jira/browse/KAFKA-622
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: bugs, improvement
> Fix For: 0.8
>
> Attachments: kafka-622-v1.patch, kafka-622-v2.patch,
> kafka-622-v3.patch
>
>
> Currently we create one mbean of each type for a given mbean server,
> regardless of the number of clients. We should create MBeans per client for
> both producer and consumer. To do that we need to introduce clientId in mbean
> names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
