[
https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509335#comment-13509335
]
Jun Rao commented on KAFKA-622:
-------------------------------
Sorry for the late review. Have a few minor questions/comments.
60. What happens if have 2 instances of Consumers with the same clientid in the
same jvm? Does one of them fail because it fails to register metrics? Ditto for
Producers.
61. ConsumerTopicStats: What if a topic is named AllTopics? We use to handle
this by adding a - in topic specific stats.
62. ZookeeperConsumerConnector: Do we need to validate groupid?
63. ClientId: Does the clientid length need to be different from topic length?
64. AbstractFetcherThread: When building a fetch request, do we need to pass in
brokerInfo as part of the client id? BrokerInfo contains the source broker info
and the fetch requests are always made to the source broker.
> Create mbeans per client
> -------------------------
>
> Key: KAFKA-622
> URL: https://issues.apache.org/jira/browse/KAFKA-622
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: bugs, improvement
> Fix For: 0.8
>
> Attachments: kafka-622-v1.patch, kafka-622-v2.patch,
> kafka-622-v3.patch, kafka-622-v4.patch, kafka-622-v5.patch, kafka-622-v6.patch
>
>
> Currently we create one mbean of each type for a given mbean server,
> regardless of the number of clients. We should create MBeans per client for
> both producer and consumer. To do that we need to introduce clientId in mbean
> names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
