[
https://issues.apache.org/jira/browse/KAFKA-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595011#comment-13595011
]
Neha Narkhede commented on KAFKA-739:
-------------------------------------
There was a conflict on DefaultEventHandler, but I reviewed the patch.
1. KafkaConfig
Should the default for log.cleaner.delete.retention.ms be 24 hours instead of 1
hour ?
2. LogCleaner
2.1 Should the check for dedup buffer be
config.dedupeBufferSize / config.numThreads > Int.MaxValue
3. DefaultEventHandler (There was a conflict, maybe you already handled this)
Need to check for null payload in the following trace-
trace("Successfully sent message:
%s".format(Utils.readString(message.message.payload)))))
4. DumpLogSegments
Should this be reading message.key instead ?
print(" key: " + Utils.readString(messageAndOffset.message.payload,
"UTF-8"))
5. SimpleKafkaETLMapper
Should probably check for null here in getData well -
ByteBuffer buf = message.payload();
6. OffsetMap6.1 If I understand correctly from getPosition(), it seems that the
probe length will change arbitrarily each time. What is the advantage of doing
this VS picking a fixed probe length that is relatively prime to the total
number of entries that the hash table can fit in ? The purpose of this property
is so that every slot in the hash table can be eventually traversed.
6.2 Why does attempts increment by 1 and not by 4 ?
7. TestLogCleaning
The purpose of dumpLogs config is not clear from the command line option
description.
> Handle null values in Message payload
> -------------------------------------
>
> Key: KAFKA-739
> URL: https://issues.apache.org/jira/browse/KAFKA-739
> Project: Kafka
> Issue Type: Bug
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Fix For: 0.8.1
>
> Attachments: KAFKA-739-v1.patch
>
>
> Add tests for null message payloads in producer, server, and consumer.
> Ensure log cleaner treats these as deletes.
> Test that null keys are rejected on dedupe logs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
