[
https://issues.apache.org/jira/browse/KAFKA-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599338#comment-13599338
]
Jun Rao commented on KAFKA-739:
-------------------------------
Thanks for patch v4. Looks good. Some minor comments:
40. IteratorTemplate: Not sure that I understand how peek() is different from
next(). If both cases, they call hasNext() and therefore move nextItem to the
next item, right?
41. LogCleaner:
41.1 Could you add some comments in the header to describe how delete retention
works?
41.2 cleanSegments(): val now not used.
42. Decoder:
42.1 Could we add a comment in the trait saying that bytes can be null?
42.2 We need to fix StringDecoder to return null if input is null.
> Handle null values in Message payload
> -------------------------------------
>
> Key: KAFKA-739
> URL: https://issues.apache.org/jira/browse/KAFKA-739
> Project: Kafka
> Issue Type: Bug
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Fix For: 0.8.1
>
> Attachments: KAFKA-739-v1.patch, KAFKA-739-v2.patch,
> KAFKA-739-v3.patch, KAFKA-739-v4.patch
>
>
> Add tests for null message payloads in producer, server, and consumer.
> Ensure log cleaner treats these as deletes.
> Test that null keys are rejected on dedupe logs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
