[
https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616783#comment-13616783
]
Joel Koshy commented on KAFKA-826:
----------------------------------
Thank you for looking into this. Metrics 2.x had a few minor issues with the
CsvReporter (which we use in the system tests) and this is why we
used 3.x.
The fixes that I'm aware of are:
- https://github.com/codahale/metrics/pull/225
- https://github.com/codahale/metrics/pull/290
- If a CSV file already exists, metrics throws an IOException and does not
resume CSV reporting. This would be the case on a broker bounce for example.
Someone put out a patch for this
(https://github.com/adagios/metrics/compare/2.x-maintenance...2.x-epoch-in-csv)
but I'd have to check if that was pulled into metrics-3.x
Unfortunately, although the above are small fixes, if we want to use the
official 2.x metrics release we would need to copy over
the code of the metrics CsvReporter (i.e., into a new implementation of
metrics' AbstractReporter), patch in those fixes and plug
that into KafkaMetricsCsvReporter. I don't think it is difficult, but a bit
clunky (which is why at the time we preferred using 3.x).
> Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
> -----------------------------------------------------
>
> Key: KAFKA-826
> URL: https://issues.apache.org/jira/browse/KAFKA-826
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Jun Rao
> Priority: Blocker
> Labels: build, kafka-0.8, metrics
>
> In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since
> metrics 3.x is a huge change as well as not an officially supported release.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
