[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617818#comment-13617818 ]
Swapnil Ghike commented on KAFKA-826: ------------------------------------- Hi Dragos, I am still not able to cleanly apply the patch. Is it created off 0.8 HEAD? Could you rebase in case it helps? Thanks. sghike@machine:~/kafka-local/kafka$ patch -p1 --dry-run < ../kafka-fix-for-826.patch patching file core/src/main/scala/kafka/cluster/Partition.scala patching file core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala Hunk #1 succeeded at 650 (offset -3 lines). patching file core/src/main/scala/kafka/controller/KafkaController.scala Hunk #1 succeeded at 97 (offset 2 lines). patching file core/src/main/scala/kafka/log/Log.scala Hunk #1 succeeded at 130 with fuzz 2 (offset 53 lines). patching file core/src/main/scala/kafka/network/RequestChannel.scala patching file core/src/main/scala/kafka/producer/async/ProducerSendThread.scala patching file core/src/main/scala/kafka/server/AbstractFetcherThread.scala Hunk #1 succeeded at 195 (offset -8 lines). patching file core/src/main/scala/kafka/server/ReplicaManager.scala Hunk #1 FAILED at 56. 1 out of 1 hunk FAILED -- saving rejects to file core/src/main/scala/kafka/server/ReplicaManager.scala.rej patching file core/src/main/scala/kafka/server/RequestPurgatory.scala patching file core/src/test/scala/unit/kafka/metrics/KafkaTimerTest.scala patching file project/Build.scala Hunk #2 FAILED at 34. 1 out of 2 hunks FAILED -- saving rejects to file project/Build.scala.rej patching file project/build/KafkaProject.scala Hunk #1 FAILED at 74. Hunk #2 FAILED at 82. 2 out of 2 hunks FAILED -- saving rejects to file project/build/KafkaProject.scala.rej > Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x > ----------------------------------------------------- > > Key: KAFKA-826 > URL: https://issues.apache.org/jira/browse/KAFKA-826 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8 > Reporter: Neha Narkhede > Assignee: Jun Rao > Priority: Blocker > Labels: build, kafka-0.8, metrics > Attachments: kafka-fix-for-826.patch > > > In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since > metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira