----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20718/#review42169 -----------------------------------------------------------
core/src/main/scala/kafka/server/BrokerStates.scala <https://reviews.apache.org/r/20718/#comment75904> This diagram is very helpful. We need an arrow from RunningAsController to RendingControlledShutdown. - Jun Rao On May 2, 2014, 7:13 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20718/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 7:13 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1384 > https://issues.apache.org/jira/browse/KAFKA-1384 > > > Repository: kafka > > > Description > ------- > > KAFKA-1384: Logging kafka state metric > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 933de9dd324c7086efe6aa610335ef370d9e9c12 > core/src/main/scala/kafka/log/Log.scala > b7bc5ffdecba7221b3d2e4bca2b0c703bc74fa12 > core/src/main/scala/kafka/log/LogManager.scala > ac67f081e6219fd2181479e7a2bb88ea6044e6cc > core/src/main/scala/kafka/server/BrokerStates.scala PRE-CREATION > core/src/main/scala/kafka/server/KafkaServer.scala > c208f83bed7fb91f07fae42f2b66892e6d46fecc > core/src/main/scala/kafka/server/KafkaServerStartable.scala > acda52b801714bcc182edc0ced925f0e4b493fc1 > > Diff: https://reviews.apache.org/r/20718/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >