-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20718/#review42197
-----------------------------------------------------------
Compilation error when trying to run the unit tests.
kafka_gradle/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala:35:
not enough arguments for constructor LogManager: (logDirs:
Array[java.io.File],topicConfigs:
scala.collection.Map[String,kafka.log.LogConfig],defaultConfig:
kafka.log.LogConfig,cleanerConfig: kafka.log.CleanerConfig,flushCheckMs:
Long,flushCheckpointMs: Long,retentionCheckMs: Long,scheduler:
kafka.utils.Scheduler,brokerState: kafka.server.BrokerState,time:
kafka.utils.Time)kafka.log.LogManager.
Unspecified value parameter brokerState.
val logManagers = configs.map(config => new LogManager(logDirs =
config.logDirs.map(new File(_)).toArray,
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala:47:
value logDirs is not a member of Nothing
for(manager <- logManagers; dir <- manager.logDirs)
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala:67:
value createLog is not a member of Nothing
val log0 = logManagers(0).createLog(TopicAndPartition(topic, 0),
LogConfig())
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala:106:
value createLog is not a member of Nothing
val topic1Log0 = logManagers(0).createLog(TopicAndPartition(topic1, 0),
LogConfig())
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala:122:
value createLog is not a member of Nothing
val topic2Log0 = logManagers(0).createLog(TopicAndPartition(topic2, 0),
LogConfig())
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:64:
not enough arguments for constructor LogManager: (logDirs:
Array[java.io.File],topicConfigs:
scala.collection.Map[String,kafka.log.LogConfig],defaultConfig:
kafka.log.LogConfig,cleanerConfig: kafka.log.CleanerConfig,flushCheckMs:
Long,flushCheckpointMs: Long,retentionCheckMs: Long,scheduler:
kafka.utils.Scheduler,brokerState: kafka.server.BrokerState,time:
kafka.utils.Time)kafka.log.LogManager.
Unspecified value parameter brokerState.
return new LogManager(logDirs,
- Jun Rao
On May 5, 2014, 6:05 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20718/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 6:05 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1384
> https://issues.apache.org/jira/browse/KAFKA-1384
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1384: Logging kafka state metric
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala
> 933de9dd324c7086efe6aa610335ef370d9e9c12
> core/src/main/scala/kafka/log/Log.scala
> b7bc5ffdecba7221b3d2e4bca2b0c703bc74fa12
> core/src/main/scala/kafka/log/LogManager.scala
> ac67f081e6219fd2181479e7a2bb88ea6044e6cc
> core/src/main/scala/kafka/server/BrokerStates.scala PRE-CREATION
> core/src/main/scala/kafka/server/KafkaServer.scala
> c208f83bed7fb91f07fae42f2b66892e6d46fecc
> core/src/main/scala/kafka/server/KafkaServerStartable.scala
> acda52b801714bcc182edc0ced925f0e4b493fc1
>
> Diff: https://reviews.apache.org/r/20718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>
