Hi All, Just wanted to know, what the next steps are wrt to the KIP?
Thanks! Sagar. On Thu, Sep 3, 2020 at 10:17 PM Sagar <sagarmeansoc...@gmail.com> wrote: > Hi John, > > Thank you! I have marked the KIP as Accepted :) > > Regarding the point on InMemoryKeyValueStore, in the PR I had added the > implementation for InMemoryKeyValueStore as well. I hadn't mentioned about > it in the KIP which I have done now as you suggested. > > Thanks! > Sagar. > > On Thu, Sep 3, 2020 at 8:10 PM John Roesler <vvcep...@apache.org> wrote: > >> Hi Sagar, >> >> Yes! Congratulations :) >> >> Now, you can mark the status of the KIP as "Accepted" and we >> can move on to reviewing your PRs. >> >> One quick note: Matthias didn't have time to review the KIP >> in full, but he did point out to me that there's a lot of >> information about the RocksDB implementation and no mention >> of the InMemory store. We both agree that we should >> implement the new method also for the InMemory store. >> Assuming you agree, note that we don't need to discuss any >> implementation details, so you could just update the KIP >> document to also mention, "We will also implement the new >> method in the InMemoryKeyValueStore." >> >> Thanks for your contribution to Apache Kafka! >> -John >> >> On Thu, 2020-09-03 at 09:30 +0530, Sagar wrote: >> > Thanks All! >> > >> > I see 3 binding +1 votes and 2 non-binding +1s. Does it mean this KIP >> has >> > gained a lazy majority? >> > >> > Thanks! >> > Sagar. >> > >> > On Thu, Sep 3, 2020 at 6:51 AM Guozhang Wang <wangg...@gmail.com> >> wrote: >> > >> > > Thanks for the KIP Sagar. I'm +1 (binding) too. >> > > >> > > >> > > Guozhang >> > > >> > > On Tue, Sep 1, 2020 at 1:24 PM Bill Bejeck <bbej...@gmail.com> wrote: >> > > >> > > > Thanks for the KIP! This is a great addition to the streams API. >> > > > >> > > > +1 (binding) >> > > > >> > > > -Bill >> > > > >> > > > On Tue, Sep 1, 2020 at 12:33 PM Sagar <sagarmeansoc...@gmail.com> >> wrote: >> > > > >> > > > > Hi All, >> > > > > >> > > > > Bumping the thread again ! >> > > > > >> > > > > Thanks! >> > > > > Sagar. >> > > > > >> > > > > On Wed, Aug 5, 2020 at 12:08 AM Sophie Blee-Goldman < >> > > sop...@confluent.io >> > > > > wrote: >> > > > > >> > > > > > Thanks Sagar! +1 (non-binding) >> > > > > > >> > > > > > Sophie >> > > > > > >> > > > > > On Sun, Aug 2, 2020 at 11:37 PM Sagar < >> sagarmeansoc...@gmail.com> >> > > > wrote: >> > > > > > > Hi All, >> > > > > > > >> > > > > > > Just thought of bumping this voting thread again to see if we >> can >> > > > form >> > > > > > any >> > > > > > > consensus around this. >> > > > > > > >> > > > > > > Thanks! >> > > > > > > Sagar. >> > > > > > > >> > > > > > > >> > > > > > > On Mon, Jul 20, 2020 at 4:21 AM Adam Bellemare < >> > > > > adam.bellem...@gmail.com >> > > > > > > wrote: >> > > > > > > >> > > > > > > > LGTM >> > > > > > > > +1 non-binding >> > > > > > > > >> > > > > > > > On Sun, Jul 19, 2020 at 4:13 AM Sagar < >> sagarmeansoc...@gmail.com >> > > > > > wrote: >> > > > > > > > > Hi All, >> > > > > > > > > >> > > > > > > > > Bumping this thread to see if there are any feedbacks. >> > > > > > > > > >> > > > > > > > > Thanks! >> > > > > > > > > Sagar. >> > > > > > > > > >> > > > > > > > > On Tue, Jul 14, 2020 at 9:49 AM John Roesler < >> > > > vvcep...@apache.org> >> > > > > > > > wrote: >> > > > > > > > > > Thanks for the KIP, Sagar! >> > > > > > > > > > >> > > > > > > > > > I’m +1 (binding) >> > > > > > > > > > >> > > > > > > > > > -John >> > > > > > > > > > >> > > > > > > > > > On Sun, Jul 12, 2020, at 02:05, Sagar wrote: >> > > > > > > > > > > Hi All, >> > > > > > > > > > > >> > > > > > > > > > > I would like to start a new voting thread for the >> below KIP >> > > > to >> > > > > > add >> > > > > > > > > prefix >> > > > > > > > > > > scan support to state stores: >> > > > > > > > > > > >> > > > > > > > > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> > > > > > > > > > > 614%3A+Add+Prefix+Scan+support+for+State+Stores >> > > > > > > > > > > < >> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-614%3A+Add+Prefix+Scan+support+for+State+Stores >> > > > > > > > > > > >> > > > > > > > > > > Thanks! >> > > > > > > > > > > Sagar. >> > > > > > > > > > > >> > > >> > > -- >> > > -- Guozhang >> > > >> >>
