Hey Gary, thanks for the suggestion. My impression is that the tech debt burden of maintaining the eos-alpha style code in the Producer is significantly less than what we have to do in Streams, since in the Producers eyes eos-alpha reduces to a subset of eos-beta/v2 in which only a single Producer/transactionalId is active across the entire consumer group.
That said, we may as well encourage non-Streams users to migrate towards eos-v2 anyways and at least reduce the surface area of the API if nothing else. I don't have a strong opinion either way, so unless anyone objects I'll add this deprecation to the KIP as well: @Deprecated public void sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata> offsets, String consumerGroupId) ; On Wed, Apr 14, 2021 at 1:54 PM Gary Russell <gruss...@vmware.com> wrote: > Sophie, > > Why not also deprecate Producer.sendOffsetsToTransaction​ method variant > with the consumerGroupId​ parameter? > > This would encourage non-Streams EOS users to move to beta/v2 > implementations, and the fallback to alpha/v1 mode code can also be removed > in 4.0. > ________________________________ > From: Sophie Blee-Goldman <sop...@confluent.io.INVALID> > Sent: Wednesday, April 14, 2021 4:38 PM > To: dev <dev@kafka.apache.org> > Subject: Re: [DISCUSS] KIP-732: Deprecate eos-alpha and replace eos-beta > with eos-v2 > > Thanks all. I've updated the KIP to clarify these will be removed in 4.0, > and added a note about > logging a warning as well. I agree that some users may set the config value > directly and could > miss the deprecation notice. > > I'll call for a vote today since there seems to be consensus, but please > let me know if you have > any more late-breaking ideas > > -Sophie > > On Wed, Apr 14, 2021 at 1:36 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > Hey John, > > > > Yes, we should definitely do that. It's meant to be the standard > procedure > > for configs that are deprecated. > > > > Ismael > > > > On Wed, Apr 14, 2021 at 12:02 PM John Roesler <vvcep...@apache.org> > wrote: > > > > > Hello again, Sophie, > > > > > > I've just had a late-breaking thought about your KIP. It > > > might be worthwhile also printing a WARN log when the > > > deprecated configs are used. People may not always be > > > referencing the StreamsConfig fields in their source code > > > when they set these configs, so it would be good to make an > > > extra effort to raise the visibility of this deprecation. > > > > > > Thanks, > > > -John > > > > > > On Wed, 2021-04-14 at 10:47 -0700, Guozhang Wang wrote: > > > > Thanks Sophie for writing the KIP! I'm +1 on the proposal. > > > > > > > > On Wed, Apr 14, 2021 at 8:56 AM Ismael Juma <ism...@juma.me.uk> > wrote: > > > > > > > > > Thanks Sophie. This makes sense to me. One question: do we want to > be > > > a bit > > > > > clearer about the removal plans? That is, can we say that the > > > deprecated > > > > > configs will be removed in 4.0 (instead of likely to be removed)? > The > > > > > implication would be that exactly-once would only work with 2.5+ > > while > > > at > > > > > least once would work with all versions. 4.0 is probably 1.5-2 > years > > > away, > > > > > so this seems reasonable to me. > > > > > > > > > > Ismael > > > > > > > > > > On Tue, Apr 13, 2021 at 7:53 PM Sophie Blee-Goldman > > > > > <sop...@confluent.io.invalid> wrote: > > > > > > > > > > > Hey all, > > > > > > > > > > > > I'd like to kick off discussion on a small KIP to move towards a > > > unified > > > > > > EOS and clean up the current options. Please give it a pass and > let > > > me > > > > > know > > > > > > what you think. > > > > > > > > > > > > KIP-732: Deprecate eos-alpha and replace eos-beta with eos-v2 > > > > > > < > > > > > > > > > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-732%253A%2BDeprecate%2Beos-alpha%2Band%2Breplace%2Beos-beta%2Bwith%2Beos-v2&data=04%7C01%7Cgrussell%40vmware.com%7Ce6b018cadb2a430f68fc08d8ff853e59%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637540295032222538%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=h5heHaemAR70PbdKJu1NzCLchMfHLUDel%2BDSnR80S%2Bs%3D&reserved=0 > > > > > > > > > > > > > KAFKA-12574: Deprecate eos-alpha > > > > > > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FKAFKA-12574&data=04%7C01%7Cgrussell%40vmware.com%7Ce6b018cadb2a430f68fc08d8ff853e59%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637540295032222538%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mNS1c%2BackYwumSJUZlU5R92HokWB6vUs%2FNkR%2BeZ0GSY%3D&reserved=0 > > > > > > > > > > > > > > Thanks, > > > > > > Sophie > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
