+1 (binding) Thanks for the KIP Just a small suggestion: in other Options classes we don't seem to prefix setters with "set", so I think we could use void reason(final String reason).
On Thu, Nov 25, 2021 at 1:48 PM Luke Chen <show...@gmail.com> wrote: > > Hi David, > Thanks for the KIP! > It is good to have the joinGroup/leaveGroup reason sent to brokers for > better troubleshooting. > > +1 (non-binding) > > Thank you. > Luke > > On Thu, Nov 25, 2021 at 8:14 AM Gwen Shapira <g...@confluent.io.invalid> > wrote: > > > +1 > > > > Thanks for driving David. Super useful. > > > > On Wed, Nov 24, 2021 at 8:53 AM David Jacot <dja...@confluent.io.invalid> > > wrote: > > > > > Hi folks, > > > > > > I'd like to start a vote on KIP-800: Add reason to LeaveGroupRequest. > > > > > > KIP: https://cwiki.apache.org/confluence/x/eYyqCw > > > > > > Please let me know what you think. > > > > > > Best, > > > David > > > > > > > > > -- > > Gwen Shapira > > Engineering Manager | Confluent > > 650.450.2760 | @gwenshap > > Follow us: Twitter | blog > >
