Thanks for the KIP, David this seems like it will be very helpful. +1(binding)
-Bill On Thu, Nov 25, 2021 at 10:02 AM David Jacot <dja...@confluent.io.invalid> wrote: > Hi Tom, > > I do agree with you. For context, this is the current reason/message logged > by the consumer when enforceRebalance is called so I just kept it as it is. > I guess that we can revise it during the implementation. > > Thanks, > David > > On Thu, Nov 25, 2021 at 3:52 PM Tom Bentley <tbent...@redhat.com> wrote: > > > > Thanks for the KIP David. > > > > It's a very trivial point, but I did wonder whether "caused" or > "requested" > > might be a better word than "enforced" in the default messages. > > > > In any case, +1 (binding). > > > > Kind regards, > > > > Tom > > > > > > > > On Thu, Nov 25, 2021 at 2:36 PM David Jacot <dja...@confluent.io.invalid > > > > wrote: > > > > > Thanks, Mickael. I have removed it. > > > > > > On Thu, Nov 25, 2021 at 3:22 PM Mickael Maison < > mickael.mai...@gmail.com> > > > wrote: > > > > > > > > +1 (binding) > > > > Thanks for the KIP > > > > > > > > Just a small suggestion: in other Options classes we don't seem to > > > > prefix setters with "set", so I think we could use void reason(final > > > > String reason). > > > > > > > > > > > > On Thu, Nov 25, 2021 at 1:48 PM Luke Chen <show...@gmail.com> wrote: > > > > > > > > > > Hi David, > > > > > Thanks for the KIP! > > > > > It is good to have the joinGroup/leaveGroup reason sent to brokers > for > > > > > better troubleshooting. > > > > > > > > > > +1 (non-binding) > > > > > > > > > > Thank you. > > > > > Luke > > > > > > > > > > On Thu, Nov 25, 2021 at 8:14 AM Gwen Shapira > <g...@confluent.io.invalid > > > > > > > > > wrote: > > > > > > > > > > > +1 > > > > > > > > > > > > Thanks for driving David. Super useful. > > > > > > > > > > > > On Wed, Nov 24, 2021 at 8:53 AM David Jacot > > > <dja...@confluent.io.invalid> > > > > > > wrote: > > > > > > > > > > > > > Hi folks, > > > > > > > > > > > > > > I'd like to start a vote on KIP-800: Add reason to > > > LeaveGroupRequest. > > > > > > > > > > > > > > KIP: https://cwiki.apache.org/confluence/x/eYyqCw > > > > > > > > > > > > > > Please let me know what you think. > > > > > > > > > > > > > > Best, > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Gwen Shapira > > > > > > Engineering Manager | Confluent > > > > > > 650.450.2760 | @gwenshap > > > > > > Follow us: Twitter | blog > > > > > > > > > > > > >
