Hi Sergio, Thanks for the KIP. I don't know anything about the log segment internals, but the logic and implementation seem sound.
Three questions: 1. Since the --max-batches-size unit is bytes, does it matter if that size doesn't align to a record boundary? 2. Can you add a check to make sure that --max-batches-size doesn't allow the user to pass in a negative number? 3. Can you add/update any unit tests related to the DumpLogSegments arguments? Thanks, Kirk On Thu, Mar 3, 2022, at 1:32 PM, Sergio Daniel Troiano wrote: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-824%3A+Allowing+dumping+segmentlogs+limiting+the+batches+in+the+output >
