Hi Sergio, Thanks for the KIP!
One question: I saw there's a `max-message-size` argument that seems to do the same thing as you want. Could you help explain what's the difference between `max-message-size` and `max-batches-size`? Thank you. Luke On Sat, Mar 5, 2022 at 3:21 AM Kirk True <k...@mustardgrain.com> wrote: > Hi Sergio, > > Thanks for the KIP. I don't know anything about the log segment internals, > but the logic and implementation seem sound. > > Three questions: > 1. Since the --max-batches-size unit is bytes, does it matter if that > size doesn't align to a record boundary? > 2. Can you add a check to make sure that --max-batches-size doesn't allow > the user to pass in a negative number? > 3. Can you add/update any unit tests related to the DumpLogSegments > arguments? > Thanks, > Kirk > > On Thu, Mar 3, 2022, at 1:32 PM, Sergio Daniel Troiano wrote: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-824%3A+Allowing+dumping+segmentlogs+limiting+the+batches+in+the+output > > >
