Hey Ron, sure, go ahead and merge this to 3.4 Thanks
On Mon, Dec 12, 2022 at 12:25 PM Ron Dagostino <rndg...@gmail.com> wrote: > Hi Sophie. https://github.com/apache/kafka/pull/12856 "KAFKA-14392: > KRaft broker heartbeat timeout should not exceed > broker.session.timeout.ms" just merged to trunk and seems like a > potential candidate for 3.4.0 as it is a very small and targeted fix > with very low risk. Could it be included even though it is not a > regression? > > Ron > > On Sat, Dec 10, 2022 at 1:00 AM Sophie Blee-Goldman > <sop...@confluent.io.invalid> wrote: > > > > Hey everyone, > > > > Rejoice (or not) for we are now past code freeze for the 3.4 release! > This > > means you > > should not be merging any new code to the 3.4 branch unless/until it's > been > > approved > > as a blocker. For now feel free to also merge things like flaky test > fixes > > and docs PRs > > that don't touch any non-testing code -- consider those automatically > > approved (though > > it never hurts to ping me for a heads up). > > > > I'll be going through the list of unresolved tickets that are still > marked > > for 3.4 and will > > bump anything that's not already approved or a flaky test ticket out to > > 3.5. So please > > take a moment to go through any open 3.4 tickets that belong to you. This > > page <https://issues.apache.org/jira/projects/KAFKA/versions/12352112> > > provides a useful view for what's still out there. > > > > As always let me know if you have any questions and make sure to raise > any > > potential > > blockers here for approval. > > > > Devij: thanks for the offer to help reenable the ARM build, but it was > only > > disabled for > > tooling reasons (often failed due to lack of available nodes). I guess > when > > we can > > finally drop support for Java 8 then we can use those nodes for the ARM > > build. > > Until then, rest assured I will still validate the 3.4 release on ARM > > > > Sophie > > > > On Fri, Dec 9, 2022 at 9:12 AM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > > > > > Hey Sophie > > > > > > I was wondering whether we should try to get the ARM build working > again so > > > that we can perform release qualification of 3.4.x on ARM as well > (which > > > was disabled in https://github.com/apache/kafka/pull/12380)? I would > be > > > happy to pick up the work if someone can point me to the history on > this > > > subject. > > > > > > -- > > > Divij Vaidya > > > > > > > > > > > > On Thu, Dec 8, 2022 at 3:48 AM Sophie Blee-Goldman > > > <sop...@confluent.io.invalid> wrote: > > > > > > > Thanks everyone for the updates, that all sounds good. > > > > > > > > Divij: I pinged some of the relevant reviewers to give your PRs a > final > > > > pass, but will > > > > leave it to their judgement from here as I'm not familiar with > either. > > > > > > > > Everyone else: reminder that today is the official code freeze > deadline, > > > so > > > > please try > > > > and get your PRs in by EOD! If you have something on the edge and > worry > > > > it's not > > > > ready, feel free to reach out for an extension: I'd rather give you > an > > > > extra day or two > > > > than risk finding a blocker weeks from now because a PR was rushed :) > > > > > > > > On Wed, Dec 7, 2022 at 2:04 PM Chris Egerton <chr...@aiven.io.invalid > > > > > > wrote: > > > > > > > > > Hi Sophie, > > > > > > > > > > Thanks for taking a look at the MM2 issue. We've merged a > > > > > (minimally-scoped) fix and backported it to the 3.4 branch; the > issue > > > > > should be resolved now. > > > > > > > > > > Cheers, > > > > > > > > > > Chris > > > > > > > > > > On Wed, Dec 7, 2022 at 3:12 PM Rajini Sivaram < > rajinisiva...@gmail.com > > > > > > > > > wrote: > > > > > > > > > > > Hi Sophie, > > > > > > > > > > > > I have merged PR #12954 for KIP-881 to 3.4 branch. Please let me > know > > > > if > > > > > > that is ok. > > > > > > > > > > > > Thank you, > > > > > > > > > > > > Rajini > > > > > > > > > > > > > > > > > > On Wed, Dec 7, 2022 at 11:43 AM Rajini Sivaram < > > > > rajinisiva...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Hi Sophie, > > > > > > > > > > > > > > The first PR for KIP-881 which contains protocol changes has > been > > > > > merged > > > > > > > to trunk (https://github.com/apache/kafka/pull/12954). It is a > > > > > > relatively > > > > > > > small PR, can we merge to 3.4.0? > > > > > > > > > > > > > > Thank you, > > > > > > > > > > > > > > Rajini > > > > > > > > > > > > > > > > > > > > > On Wed, Dec 7, 2022 at 11:16 AM Divij Vaidya < > > > > divijvaidy...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > >> Hey Sophie > > > > > > >> > > > > > > >> I have a couple of pending PRs which have been waiting for > review > > > > > since > > > > > > >> preparation of the 3.3 release. They are not blockers for 3.4 > but > > > > are > > > > > > >> being > > > > > > >> tracked as improvements that we would like to add to 3.4 > release. > > > > > > >> > > > > > > >> Please consider taking a look when you get a chance: > > > > > > >> > > > > > > >> 1. https://issues.apache.org/jira/browse/KAFKA-7109 > > > > > > >> 2. https://github.com/apache/kafka/pull/12228 > > > > > > >> > > > > > > >> -- > > > > > > >> Divij Vaidya > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> On Wed, Dec 7, 2022 at 3:18 AM Sophie Blee-Goldman > > > > > > >> <sop...@confluent.io.invalid> wrote: > > > > > > >> > > > > > > >> > Hey all, > > > > > > >> > > > > > > > >> > First off, just a heads up that code freeze will be > *tomorrow, > > > Dec > > > > > > 6th* > > > > > > >> so > > > > > > >> > please make sure > > > > > > >> > to merge any lingering PRs by EOD Wednesday (PST). If you > have a > > > > > > >> potential > > > > > > >> > blocker > > > > > > >> > that may take longer to fix and hasn't already been > communicated > > > > to > > > > > > me, > > > > > > >> > please reach out > > > > > > >> > to me now and make sure the ticket is marked as a blocker > for > > > 3.4 > > > > > > >> > > > > > > > >> > Also note that the 3.4 branch has been created, so going > forward > > > > > > you'll > > > > > > >> > need to ensure that > > > > > > >> > newly merged PRs are cherrypicked to this branch to make > the 3.4 > > > > > > >> release. > > > > > > >> > > > > > > > >> > Thanks, and don't hesitate to reach out if you have any > > > questions. > > > > > > >> > > > > > > > >> > Greg/Chris -- I looked over the ticket and PR and agree this > > > > counts > > > > > > as a > > > > > > >> > blocker so just try > > > > > > >> > and get this in as quickly as is reasonable. It seems like > > > things > > > > > are > > > > > > >> > mostly sorted with this > > > > > > >> > fix but I did chime in on the PR discussion regarding > keeping > > > the > > > > > > scope > > > > > > >> > small here > > > > > > >> > > > > > > > >> > > > > > > > >> > On Tue, Dec 6, 2022 at 7:15 AM Chris Egerton > > > > > <chr...@aiven.io.invalid > > > > > > > > > > > > > >> > wrote: > > > > > > >> > > > > > > > >> > > Hi Greg, > > > > > > >> > > > > > > > > >> > > Thanks for finding and raising this issue. I've given the > PR a > > > > > look > > > > > > >> and > > > > > > >> > > plan to continue reviewing it this week until merged. IMO > this > > > > > > should > > > > > > >> > > qualify as a blocker for the release. > > > > > > >> > > > > > > > > >> > > Sophie, is it alright if we merge this into the 3.4 > branch (or > > > > > > trunk, > > > > > > >> if > > > > > > >> > > one has not been created yet) past the December 7th code > > > freeze > > > > > > >> deadline? > > > > > > >> > > > > > > > > >> > > Cheers, > > > > > > >> > > > > > > > > >> > > Chris > > > > > > >> > > > > > > > > >> > > On Mon, Dec 5, 2022 at 2:11 PM Greg Harris > > > > > > >> <greg.har...@aiven.io.invalid > > > > > > >> > > > > > > > > >> > > wrote: > > > > > > >> > > > > > > > > >> > > > Hi All, > > > > > > >> > > > > > > > > > >> > > > Just notifying everyone of a regression introduced by > > > KIP-787, > > > > > > >> > currently > > > > > > >> > > > only present on trunk, but which may qualify as a > blocker > > > for > > > > > the > > > > > > >> > > release. > > > > > > >> > > > It manifests as a moderate resource leak on MirrorMaker2 > > > > > clusters. > > > > > > >> The > > > > > > >> > > fix > > > > > > >> > > > should have a small scope and low risk. > > > > > > >> > > > > > > > > > >> > > > Here's the bug ticket: > > > > > > >> > https://issues.apache.org/jira/browse/KAFKA-14443 > > > > > > >> > > > Here's the tentative fix PR: > > > > > > >> > https://github.com/apache/kafka/pull/12955 > > > > > > >> > > > > > > > > > >> > > > Thanks! > > > > > > >> > > > Greg > > > > > > >> > > > > > > > > > >> > > > On Fri, Dec 2, 2022 at 8:06 AM David Jacot > > > > > > >> <dja...@confluent.io.invalid > > > > > > >> > > > > > > > > >> > > > wrote: > > > > > > >> > > > > > > > > > >> > > > > Hi Sophie, > > > > > > >> > > > > > > > > > > >> > > > > FYI - I just merged KIP-840 > > > > > > >> > > > > ( > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211884652 > > > > > > >> > > > > ) > > > > > > >> > > > > so it will be in 3.4. > > > > > > >> > > > > > > > > > > >> > > > > Best, > > > > > > >> > > > > David > > > > > > >> > > > > > > > > > > >> > > > > On Thu, Dec 1, 2022 at 3:01 AM Sophie Blee-Goldman > > > > > > >> > > > > <sop...@confluent.io.invalid> wrote: > > > > > > >> > > > > > > > > > > > >> > > > > > Hey all! It's officially *feature freeze for 3.4* so > > > make > > > > > sure > > > > > > >> you > > > > > > >> > > get > > > > > > >> > > > > that > > > > > > >> > > > > > feature work merged by the end of today. > > > > > > >> > > > > > After this point, only bug fixes and other work > focused > > > on > > > > > > >> > > stabilizing > > > > > > >> > > > > the > > > > > > >> > > > > > release should be merged to the release > > > > > > >> > > > > > branch. Also note that the *3.4 code freeze* will > be in > > > > one > > > > > > week > > > > > > >> > > (*Dec > > > > > > >> > > > > 7th*) > > > > > > >> > > > > > so please make sure to stabilize and > > > > > > >> > > > > > thoroughly test any new features. > > > > > > >> > > > > > > > > > > > >> > > > > > I will wait until Friday to create the release > branch to > > > > > allow > > > > > > >> for > > > > > > >> > > any > > > > > > >> > > > > > existing PRs to be merged. After this point you'll > > > > > > >> > > > > > need to cherrypick any new commits to the 3.4 branch > > > once > > > > a > > > > > PR > > > > > > >> is > > > > > > >> > > > merged. > > > > > > >> > > > > > > > > > > > >> > > > > > Finally, I've updated the list of KIPs targeted for > 3.4. > > > > > > Please > > > > > > >> > check > > > > > > >> > > > out > > > > > > >> > > > > > the Planned KIP Content on the release > > > > > > >> > > > > > plan and let me know if there is anything missing or > > > > > incorrect > > > > > > >> on > > > > > > >> > > > there. > > > > > > >> > > > > > > > > > > > >> > > > > > Cheers, > > > > > > >> > > > > > Sophie > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > On Wed, Nov 30, 2022 at 12:29 PM David Arthur < > > > > > > mum...@gmail.com > > > > > > >> > > > > > > > >> > > > wrote: > > > > > > >> > > > > > > > > > > > >> > > > > > > Sophie, KIP-866 has been accepted. Thanks! > > > > > > >> > > > > > > > > > > > > >> > > > > > > -David > > > > > > >> > > > > > > > > > > > > >> > > > > > > On Thu, Nov 17, 2022 at 12:21 AM Sophie > Blee-Goldman > > > > > > >> > > > > > > <sop...@confluent.io.invalid> wrote: > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > Thanks for the update Rajini, I've added this > to the > > > > > > release > > > > > > >> > page > > > > > > >> > > > > since > > > > > > >> > > > > > > it > > > > > > >> > > > > > > > looks like > > > > > > >> > > > > > > > it will pass but of course if anything changes, > just > > > > let > > > > > > me > > > > > > >> > know. > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > David, I'm fine with aiming to include KIP-866 > in > > > the > > > > > 3.4 > > > > > > >> > release > > > > > > >> > > > as > > > > > > >> > > > > well > > > > > > >> > > > > > > > since this > > > > > > >> > > > > > > > seems to be a critical part of the zookeeper > > > > > > >> removal/migration. > > > > > > >> > > > > Please > > > > > > >> > > > > > > let > > > > > > >> > > > > > > > me know > > > > > > >> > > > > > > > when it's been accepted > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > On Wed, Nov 16, 2022 at 11:08 AM Rajini Sivaram > < > > > > > > >> > > > > rajinisiva...@gmail.com > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > wrote: > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > Hi Sophie, > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > KIP-881 has three binding votes (David Jacot, > Jun > > > > and > > > > > > me) > > > > > > >> and > > > > > > >> > > one > > > > > > >> > > > > > > > > non-binding vote (Maulin). So it is good to > go for > > > > > 3.4.0 > > > > > > >> if > > > > > > >> > > there > > > > > > >> > > > > are > > > > > > >> > > > > > > no > > > > > > >> > > > > > > > > objections until the voting time of 72 hours > > > > completes > > > > > > on > > > > > > >> > > Friday. > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > Thanks, > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > Rajini > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > On Wed, Nov 16, 2022 at 3:15 PM David Arthur > > > > > > >> > > > > > > > > <david.art...@confluent.io.invalid> wrote: > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > Sophie, the vote for KIP-866 is underway, > but > > > > there > > > > > is > > > > > > >> > still > > > > > > >> > > > some > > > > > > >> > > > > > > > > > discussion happening. I'm hopeful that the > vote > > > > can > > > > > > >> close > > > > > > >> > > this > > > > > > >> > > > > week, > > > > > > >> > > > > > > but > > > > > > >> > > > > > > > > it > > > > > > >> > > > > > > > > > may fall into next week. Can we include > this KIP > > > > in > > > > > > 3.4? > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > Thanks, > > > > > > >> > > > > > > > > > David > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > On Tue, Nov 15, 2022 at 6:52 AM Rajini > Sivaram < > > > > > > >> > > > > > > rajinisiva...@gmail.com> > > > > > > >> > > > > > > > > > wrote: > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > Hi Sophie, > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > I was out of office and hence couldn't get > > > > voting > > > > > > >> started > > > > > > >> > > for > > > > > > >> > > > > > > KIP-881 > > > > > > >> > > > > > > > > in > > > > > > >> > > > > > > > > > > time. I will start the vote for the KIP > today. > > > > If > > > > > > >> there > > > > > > >> > are > > > > > > >> > > > > > > sufficient > > > > > > >> > > > > > > > > > > votes by tomorrow (16th Nov), can we > include > > > > this > > > > > > KIP > > > > > > >> in > > > > > > >> > > 3.4, > > > > > > >> > > > > even > > > > > > >> > > > > > > > > though > > > > > > >> > > > > > > > > > > voting will only complete on the 17th? It > is a > > > > > small > > > > > > >> KIP, > > > > > > >> > > so > > > > > > >> > > > > we can > > > > > > >> > > > > > > > > merge > > > > > > >> > > > > > > > > > > by feature freeze. > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > Thank you, > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > Rajini > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > On Thu, Nov 10, 2022 at 4:02 PM Sophie > > > > > Blee-Goldman > > > > > > >> > > > > > > > > > > <sop...@confluent.io.invalid> wrote: > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > Hello again, > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > This is a reminder that the KIP freeze > > > > deadline > > > > > is > > > > > > >> > > > > approaching, > > > > > > >> > > > > > > all > > > > > > >> > > > > > > > > > KIPs > > > > > > >> > > > > > > > > > > > must be voted > > > > > > >> > > > > > > > > > > > and accepted by *next Wednesday* *(the > > > 16th)* > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > Keep in mind that to allow for the full > > > voting > > > > > > >> period, > > > > > > >> > > this > > > > > > >> > > > > > > means you > > > > > > >> > > > > > > > > > > must > > > > > > >> > > > > > > > > > > > kick off the > > > > > > >> > > > > > > > > > > > vote for your KIP no later than* next > > > Monday* > > > > > > (*the > > > > > > >> > > 14th*). > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > The feature freeze deadline will be 2 > weeks > > > > > after > > > > > > >> this, > > > > > > >> > > so > > > > > > >> > > > > make > > > > > > >> > > > > > > sure > > > > > > >> > > > > > > > > to > > > > > > >> > > > > > > > > > > get > > > > > > >> > > > > > > > > > > > your KIPs in! > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > Best, > > > > > > >> > > > > > > > > > > > Sophie > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > On Tue, Oct 18, 2022 at 2:01 PM Sophie > > > > > > Blee-Goldman > > > > > > >> < > > > > > > >> > > > > > > > > > sop...@confluent.io > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > wrote: > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > Hey all, > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > I've created the release page for > 3.4.0 > > > with > > > > > the > > > > > > >> > > current > > > > > > >> > > > > plan, > > > > > > >> > > > > > > > > which > > > > > > >> > > > > > > > > > > you > > > > > > >> > > > > > > > > > > > > can find here: > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > >> > > > > https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.4.0 > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > The freeze deadlines for this release > are > > > as > > > > > > >> follows: > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > 1. KIP Freeze November 16th, 2022 > > > > > > >> > > > > > > > > > > > > 2. Feature Freeze November 30th, 2022 > > > > > > >> > > > > > > > > > > > > 3. Code Freeze December 7th, 2022 > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > Please take a look at the list of > planned > > > > KIPs > > > > > > for > > > > > > >> > > 3.4.0 > > > > > > >> > > > > and > > > > > > >> > > > > > > let me > > > > > > >> > > > > > > > > > > know > > > > > > >> > > > > > > > > > > > > if you have any > > > > > > >> > > > > > > > > > > > > others that you are targeting in the > > > > upcoming > > > > > > >> > release. > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > Cheers, > > > > > > >> > > > > > > > > > > > > Sophie > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > On Mon, Oct 10, 2022 at 9:22 AM > Matthew > > > > > Benedict > > > > > > >> de > > > > > > >> > > > Detrich > > > > > > >> > > > > > > > > > > > > <matthew.dedetr...@aiven.io.invalid> > > > wrote: > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > >> Thanks for volunteering! > > > > > > >> > > > > > > > > > > > >> > > > > > > >> > > > > > > > > > > > >> On Mon, 10 Oct 2022, 10:56 Bruno > > > Cadonna, < > > > > > > >> > > > > cado...@apache.org > > > > > > >> > > > > > > > > > > > > > >> > > > > > > > > > wrote: > > > > > > >> > > > > > > > > > > > >> > > > > > > >> > > > > > > > > > > > >> > +1 > > > > > > >> > > > > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > >> > Thanks Sophie! > > > > > > >> > > > > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > >> > Best, > > > > > > >> > > > > > > > > > > > >> > Bruno > > > > > > >> > > > > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > >> > On 06.10.22 00:01, Sophie > Blee-Goldman > > > > > wrote: > > > > > > >> > > > > > > > > > > > >> > > Hey all, > > > > > > >> > > > > > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > >> > > I'd like to volunteer as release > > > > manager > > > > > > for > > > > > > >> the > > > > > > >> > > > next > > > > > > >> > > > > > > feature > > > > > > >> > > > > > > > > > > > release, > > > > > > >> > > > > > > > > > > > >> > > which will be Apache > > > > > > >> > > > > > > > > > > > >> > > Kafka 3.4.0. If that sounds good > to > > > > > > everyone > > > > > > >> > I'll > > > > > > >> > > > > update > > > > > > >> > > > > > > this > > > > > > >> > > > > > > > > > > thread > > > > > > >> > > > > > > > > > > > >> with > > > > > > >> > > > > > > > > > > > >> > > the release plan in the coming > week. > > > > > > >> > > > > > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > >> > > Cheers, > > > > > > >> > > > > > > > > > > > >> > > A. Sophie Blee-Goldman > > > > > > >> > > > > > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > -- > > > > > > >> > > > > > > > > > -David > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > > > >> > > > > > > -- > > > > > > >> > > > > > > David Arthur > > > > > > >> > > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > >
