Hi Ismael, Good point! This file hasn't been changed after 2020 Oct.. So I think this is not a blocker for v3.4.0.
Thank you. Luke On Wed, Dec 21, 2022 at 9:49 PM Ismael Juma <ism...@juma.me.uk> wrote: > Hi Luke, > > Is this a recent change? If not, that gives further credence that we don't > use this method today. > > Ismael > > On Wed, Dec 21, 2022 at 2:22 AM Luke Chen <show...@gmail.com> wrote: > > > Hi Sophie and devs, > > > > KAFKA-14540 <https://issues.apache.org/jira/browse/KAFKA-14540> is > > reported > > (from Michael Marshall, thanks!) that we might write corrupted data to > the > > output stream due to the wrong buffer position set in > > DataOutputStreamWritable#writeByteBuffer. > > Had a search in the project, it looks like there is no place using this > > method directly. > > But I'd like to make sure I didn't miss anything and make things worse > > after we release it. > > > > Thank you. > > Luke > > > > On Wed, Dec 21, 2022 at 4:36 PM David Jacot <dja...@confluent.io.invalid > > > > wrote: > > > > > Hi Sophie, > > > > > > I have merged https://issues.apache.org/jira/browse/KAFKA-14532. > > > > > > Best, > > > David > > > > > > On Tue, Dec 20, 2022 at 4:31 PM David Arthur > > > <david.art...@confluent.io.invalid> wrote: > > > > > > > > Hey Sophie, > > > > > > > > I found a KRaft blocker for 3.4 > > > > https://issues.apache.org/jira/browse/KAFKA-14531. The fix is > > committed > > > to > > > > trunk and is quite small. If you agree, I'll merge the fix to the 3.4 > > > > branch. > > > > > > > > Thanks! > > > > David > > > > > > > > On Tue, Dec 20, 2022 at 7:53 AM David Jacot > > <dja...@confluent.io.invalid > > > > > > > > wrote: > > > > > > > > > Hi Sophie, > > > > > > > > > > We just found a blocker for 3.4.0: > > > > > https://issues.apache.org/jira/browse/KAFKA-14532. The PR is on > the > > > > > way. > > > > > > > > > > Best, > > > > > David > > > > > > > > > > On Sat, Dec 17, 2022 at 1:08 AM Sophie Blee-Goldman > > > > > <sop...@confluent.io.invalid> wrote: > > > > > > > > > > > > Thanks Jose & Kirk. I agree both those fixes should be included > in > > > the > > > > > 3.4 > > > > > > release > > > > > > > > > > > > On Fri, Dec 16, 2022 at 12:30 PM José Armando García Sancio > > > > > > <jsan...@confluent.io.invalid> wrote: > > > > > > > > > > > > > Hi Sophie, > > > > > > > > > > > > > > I am interested in including a bug fix for > > > > > > > https://issues.apache.org/jira/browse/KAFKA-14457 in the 3.4.0 > > > > > > > release. The fix is here: > > > https://github.com/apache/kafka/pull/12994. > > > > > > > > > > > > > > I think it is important to include this fix because some of the > > > > > > > controller metrics are inaccurate without this fix. This could > > > impact > > > > > > > some users' ability to monitor the cluster. > > > > > > > > > > > > > > What do you think? > > > > > > > -- > > > > > > > -José > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > -David > > > > > >
