Hi Matthias,

Yes, I agree we should get this hotfix into 3.4.1.
I've backported into the 3.4 branch.
I'll create a new RC for 3.4.1.

Thanks.
Luke

On Mon, May 22, 2023 at 5:13 AM Matthias J. Sax <mj...@apache.org> wrote:

> Hi Luke,
>
> RC0 for 3.4.1 includes a fix for
> https://issues.apache.org/jira/browse/KAFKA-14862. We recently
> discovered that tge fix itself introduces a regression. We have already
> a PR to fix-forward the regression:
> https://github.com/apache/kafka/pull/13734
>
> I think we should get the open PR merged, and back part not only to 3.5,
> but also to 3.4.1, and get a new RC for 3.4.1.
>
> Thoughts?
>
>
> -Matthias
>
>
> On 5/19/23 6:12 AM, Josep Prat wrote:
> > Hi Luke,
> > This gets a +1 from my end. I believe non-binding because if I understand
> > it correctly, binding votes for releases are only issued by PMCs (
> >
> https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Afterthevotepasses
> > ).
> >
> > I did the following validations:
> > - Verified signatures and checksums for all the generated artifacts
> > - Built from source with Java 11 and Scala 2.13.10
> > - Run unit tests
> > - Run integration tests
> > - Run the quickstart with Zookeeper and KRaft
> >
> > Best,
> >
> > On Wed, May 17, 2023 at 2:11 PM Josep Prat <josep.p...@aiven.io> wrote:
> >
> >> Hi Luke,
> >>
> >> I ran the tests from the source package you created and I didn't get any
> >> of the test failures you had on your CI build. I got other flaky tests
> >> though, that after being run in isolation ran successfully. I'll try to
> run
> >> signature validation, and some further testing later today or later this
> >> week.
> >>
> >> Best,
> >>
> >> On Wed, May 17, 2023 at 12:43 PM Federico Valeri <fedeval...@gmail.com>
> >> wrote:
> >>
> >>> Hi Luke, thanks for running the release.
> >>>
> >>> Looks like the Maven artifacts are not in staging:
> >>>
> >>>
> https://repository.apache.org/content/groups/staging/org/apache/kafka/kafka-clients/3.4.1/
> >>>
> >>> Documentation still has 3.4.0, instead of 3.4.1 (not sure if this will
> >>> be aligned later):
> >>> https://kafka.apache.org/34/documentation.html#producerapi
> >>>
> >>> Br
> >>> Fede
> >>>
> >>>
> >>> On Wed, May 17, 2023 at 5:24 AM Luke Chen <show...@gmail.com> wrote:
> >>>>
> >>>> Hello Kafka users, developers and client-developers,
> >>>>
> >>>> This is the first candidate for release of Apache Kafka 3.4.1.
> >>>>
> >>>> This is a bugfix release with several fixes since the release of
> 3.4.0.
> >>> A
> >>>> few of the major issues include:
> >>>> - core
> >>>> KAFKA-14644 <https://issues.apache.org/jira/browse/KAFKA-14644>
> Process
> >>>> should stop after failure in raft IO thread
> >>>> KAFKA-14946 <https://issues.apache.org/jira/browse/KAFKA-14946> KRaft
> >>>> controller node shutting down while renouncing leadership
> >>>> KAFKA-14887 <https://issues.apache.org/jira/browse/KAFKA-14887> ZK
> >>> session
> >>>> timeout can cause broker to shutdown
> >>>> - client
> >>>> KAFKA-14639 <https://issues.apache.org/jira/browse/KAFKA-14639> Kafka
> >>>> CooperativeStickyAssignor revokes/assigns partition in one rebalance
> >>> cycle
> >>>> - connect
> >>>> KAFKA-12558 <https://issues.apache.org/jira/browse/KAFKA-12558> MM2
> >>> may not
> >>>> sync partition offsets correctly
> >>>> KAFKA-14666 <https://issues.apache.org/jira/browse/KAFKA-14666> MM2
> >>> should
> >>>> translate consumer group offsets behind replication flow
> >>>> - stream
> >>>> KAFKA-14172 <https://issues.apache.org/jira/browse/KAFKA-14172> bug:
> >>> State
> >>>> stores lose state when tasks are reassigned under EOS
> >>>>
> >>>> Release notes for the 3.4.1 release:
> >>>> https://home.apache.org/~showuon/kafka-3.4.1-rc0/RELEASE_NOTES.html
> >>>>
> >>>> *** Please download, test and vote by May 24, 2023
> >>>> Kafka's KEYS file containing PGP keys we use to sign the release:
> >>>> https://kafka.apache.org/KEYS
> >>>>
> >>>> * Release artifacts to be voted upon (source and binary):
> >>>> https://home.apache.org/~showuon/kafka-3.4.1-rc0/
> >>>>
> >>>> * Maven artifacts to be voted upon:
> >>>>
> https://repository.apache.org/content/groups/staging/org/apache/kafka/
> >>>>
> >>>> * Javadoc:
> >>>> https://home.apache.org/~showuon/kafka-3.4.1-rc0/javadoc/
> >>>>
> >>>> * Tag to be voted upon (off 3.4 branch) is the 3.4.1 tag:
> >>>> https://github.com/apache/kafka/releases/tag/3.4.1-rc0
> >>>>
> >>>> * Documentation:
> >>>> https://kafka.apache.org/34/documentation.html
> >>>>
> >>>> * Protocol:
> >>>> https://kafka.apache.org/34/protocol.html
> >>>>
> >>>> The most recent build has had test failures. These all appear to be
> due
> >>> to
> >>>> flakiness, but it would be nice if someone more familiar with the
> failed
> >>>> tests could confirm this. I may update this thread with passing build
> >>> links
> >>>> if I can get one, or start a new release vote thread if test failures
> >>> must
> >>>> be addressed beyond re-running builds until they pass.
> >>>>
> >>>> Unit/integration tests:
> >>>> https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.4/133/
> >>>>
> >>>> System tests:
> >>>> Will update the results later
> >>>>
> >>>> Thank you.
> >>>> Luke
> >>>
> >>
> >>
> >> --
> >> [image: Aiven] <https://www.aiven.io>
> >>
> >> *Josep Prat*
> >> Open Source Engineering Director, *Aiven*
> >> josep.p...@aiven.io   |   +491715557497
> >> aiven.io <https://www.aiven.io>   |
> >> <https://www.facebook.com/aivencloud>
> >> <https://www.linkedin.com/company/aiven/>   <
> https://twitter.com/aiven_io>
> >> *Aiven Deutschland GmbH*
> >> Alexanderufer 3-7, 10117 Berlin
> >> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> >> Amtsgericht Charlottenburg, HRB 209739 B
> >>
> >
> >
>

Reply via email to