Hi David, Thanks for the update. Please get it reviewed sooner. I plan to create RC1 in the next 5 hrs. As it is not a release blocker, I will merge it if this PR is approved and jenkins job looks good within that time.
Thanks, Satish. On Wed, 20 Sept 2023 at 01:42, David Arthur <david.art...@confluent.io.invalid> wrote: > > As part of validating this RC, I found that most of the ZK migration system > tests were failing. I investigated this today and found that it was just > problems in the test code. This is not a blocker, but since we're doing > RC1, I'd like to include it https://github.com/apache/kafka/pull/14409 > > On Tue, Sep 19, 2023 at 12:57 PM Satish Duggana <satish.dugg...@gmail.com> > wrote: > > > Hi All, > > I will start creating a new RC with the fix and send it for a vote by > > tomorrow as https://issues.apache.org/jira/browse/KAFKA-15473 is > > determined to be a release blocker. > > > > Thanks. > > Satish. > > > > On Tue, 19 Sept 2023 at 22:26, Satish Duggana <satish.dugg...@gmail.com> > > wrote: > > > > > > Thanks Chris for your comment on the reported issue. > > > > > > ~Satish. > > > > > > On Tue, 19 Sept 2023 at 22:16, Chris Egerton <chr...@aiven.io.invalid> > > wrote: > > > > > > > > Hi all, > > > > > > > > Given the regression raised by Greg Harris ( > > > > https://issues.apache.org/jira/browse/KAFKA-15473) on the release > > thread, I > > > > believe we should generate a new candidate with a fix. > > > > > > > > I'm -1 (binding) on this RC. > > > > > > > > Best, > > > > > > > > Chris > > > > > > > > On Tue, Sep 19, 2023 at 10:30 AM Christo Lolov <christolo...@gmail.com > > > > > > > wrote: > > > > > > > > > Heya, > > > > > > > > > > I have compiled and ran the test target successfully for the > > 3.6.0-rc0 > > > > > branch on: > > > > > > > > > > Java 11, Scala 2.13 - ARM > > > > > Java 17, Scala 2.13 - ARM > > > > > Java 20, Scala 2.18 - ARM > > > > > Java 11, Scala 2.13 - Intel x86 > > > > > Java 17, Scala 2.13 - Intel x86 > > > > > Java 20, Scala 2.13 - Intel x86 > > > > > > > > > > I will update the Zookeeper KIP title in the KIPs page, that's my > > miss > > > > > > > > > > Best, > > > > > Christo > > > > > > > > > > On Tue, 19 Sept 2023 at 13:21, Divij Vaidya <divijvaidy...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > Hey Satish > > > > > > > > > > > > Thank you for managing this release. I have a few comments: > > > > > > > > > > > > Documentation > > > > > > > > > > > > 1. Section: Zookeeper/Stable Version - The documentation states > > "The > > > > > > current stable branch is 3.5. Kafka is regularly updated to include > > > > > > the latest release in the 3.5 series." in the ZooKeeper section. > > That > > > > > > needs an update since we are running Zk 3.8 now. > > > > > > > > > > > > 2. Section: Zookeeper/Migration - The documentation states > > "Migration > > > > > > of an existing ZooKeeper based Kafka cluster to KRaft is currently > > > > > > Preview and we expect it to be ready for production usage in > > version > > > > > > 3.6.". This probably needs an update on whether it is production > > ready > > > > > > or not in 3.6 > > > > > > > > > > > > 3. Section: Kraft/missing features > > > > > > (https://kafka.apache.org/36/documentation.html#kraft_missing) - I > > > > > > believe that delegation token is now part of 3.6? I think this > > > > > > probably needs an update. > > > > > > > > > > > > 4. Section: Configuration/rack.aware.assignment.strategy - there > > seems > > > > > > to be a formatting problem starting from here > > > > > > ( > > > > > > > > > > > > > https://kafka.apache.org/36/documentation.html#streamsconfigs_rack.aware.assignment.strategy > > > > > > ) > > > > > > > > > > > > 5. Section: KRaft Monitoring - Newly added metrics in > > > > > > https://issues.apache.org/jira/browse/KAFKA-15183 are missing > > from the > > > > > > documentation here. > > > > > > > > > > > > Release notes > > > > > > > > > > > > 1. I found a bunch of tickets which have not been marked with a > > > > > > release version but have been resolved in last 6 months using the > > > > > > query > > > > > > > > > > > > > https://issues.apache.org/jira/browse/KAFKA-15380?jql=project%20%3D%20KAFKA%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20EMPTY%20AND%20resolved%20%3E%3D%20-24w%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC > > > > > > . Are some of them targeted for 3.6 release? > > > > > > > > > > > > 2. The KIP "KIP-902: Upgrade Zookeeper to 3.8.1" should probably be > > > > > > renamed to include 3.8.2 since code uses version 3.8.2 of > > Zookeeper. > > > > > > > > > > > > > > > > > > Additionally, I have verified the following: > > > > > > 1. release tag is correctly made after the latest commit on the 3.6 > > > > > > branch at > > > > > > > > > > > > > https://github.com/apache/kafka/commit/193d8c5be8d79b64c6c19d281322f09e3c5fe7de > > > > > > > > > > > > 2. protocol documentation contains the newly introduced error code > > as > > > > > > part of tiered storage > > > > > > > > > > > > 3. verified that public keys for RM are available at > > > > > > https://keys.openpgp.org/ > > > > > > > > > > > > 4. verified that public keys for RM are available at > > > > > > https://people.apache.org/keys/committer/ > > > > > > > > > > > > -- > > > > > > Divij Vaidya > > > > > > > > > > > > On Tue, Sep 19, 2023 at 12:41 PM Sagar <sagarmeansoc...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > Hey Satish, > > > > > > > > > > > > > > I have commented on KAFKA-15473. I think the changes in the PR > > look > > > > > > fine. I > > > > > > > also feel this need not be a release blocker given there are > > other > > > > > > > possibilities in which duplicates can manifest on the response > > of the > > > > > end > > > > > > > point in question (albeit we can potentially see more in number > > due to > > > > > > > this). > > > > > > > > > > > > > > Would like to hear others' thoughts as well. > > > > > > > > > > > > > > Thanks! > > > > > > > Sagar. > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 19, 2023 at 3:14 PM Satish Duggana < > > > > > satish.dugg...@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Greg, > > > > > > > > Thanks for reporting the KafkaConnect issue. I replied to this > > issue > > > > > > > > on "Apache Kafka 3.6.0 release" email thread and on > > > > > > > > https://issues.apache.org/jira/browse/KAFKA-15473. > > > > > > > > > > > > > > > > I would like to hear other KafkaConnect experts' opinions on > > whether > > > > > > > > this issue is really a release blocker. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Satish. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, 19 Sept 2023 at 00:27, Greg Harris > > > > > > <greg.har...@aiven.io.invalid> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hey all, > > > > > > > > > > > > > > > > > > I noticed this regression in RC0: > > > > > > > > > https://issues.apache.org/jira/browse/KAFKA-15473 > > > > > > > > > I've mentioned it in the release thread, and I'm working on > > a fix. > > > > > > > > > > > > > > > > > > I'm -1 (non-binding) until we determine if this regression > > is a > > > > > > blocker. > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > On Mon, Sep 18, 2023 at 10:56 AM Josep Prat > > > > > > <josep.p...@aiven.io.invalid> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Hi Satish, > > > > > > > > > > Thanks for running the release. > > > > > > > > > > > > > > > > > > > > I ran the following validation steps: > > > > > > > > > > - Built from source with Java 11 and Scala 2.13 > > > > > > > > > > - Verified Signatures and hashes of the artifacts generated > > > > > > > > > > - Navigated through Javadoc including links to JDK classes > > > > > > > > > > - Run the unit tests > > > > > > > > > > - Run integration tests > > > > > > > > > > - Run the quickstart in KRaft and Zookeeper mode > > > > > > > > > > - Checked License-binary against libs and matched them > > > > > > > > > > > > > > > > > > > > I +1 this release (non-binding) > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > > > > > > > On Mon, Sep 18, 2023 at 6:02 PM David Arthur < > > mum...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hey Satish, thanks for getting the RC underway! > > > > > > > > > > > > > > > > > > > > > > I noticed that the PR for the 3.6 blog post is merged. > > This > > > > > makes > > > > > > > > the blog > > > > > > > > > > > post live on the Kafka website > > > > > > https://kafka.apache.org/blog.html. > > > > > > > > The > > > > > > > > > > > blog > > > > > > > > > > > post (along with other public announcements) is usually > > the > > > > > last > > > > > > > > thing we > > > > > > > > > > > do as part of the release. I think we should probably > > take this > > > > > > down > > > > > > > > until > > > > > > > > > > > we're done with the release, otherwise users stumbling > > on this > > > > > > post > > > > > > > > could > > > > > > > > > > > get confused. It also contains some broken links. > > > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > On Sun, Sep 17, 2023 at 1:31 PM Satish Duggana < > > > > > > > > satish.dugg...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hello Kafka users, developers and client-developers, > > > > > > > > > > > > > > > > > > > > > > > > This is the first candidate for the release of Apache > > Kafka > > > > > > 3.6.0. > > > > > > > > Some > > > > > > > > > > > of > > > > > > > > > > > > the major features include: > > > > > > > > > > > > > > > > > > > > > > > > * KIP-405 : Kafka Tiered Storage > > > > > > > > > > > > * KIP-868 : KRaft Metadata Transactions > > > > > > > > > > > > * KIP-875: First-class offsets support in Kafka Connect > > > > > > > > > > > > * KIP-898: Modernize Connect plugin discovery > > > > > > > > > > > > * KIP-938: Add more metrics for measuring KRaft > > performance > > > > > > > > > > > > * KIP-902: Upgrade Zookeeper to 3.8.1 > > > > > > > > > > > > * KIP-917: Additional custom metadata for remote log > > segment > > > > > > > > > > > > > > > > > > > > > > > > Release notes for the 3.6.0 release: > > > > > > > > > > > > > > > > > > > > > > https://home.apache.org/~satishd/kafka-3.6.0-rc0/RELEASE_NOTES.html > > > > > > > > > > > > > > > > > > > > > > > > *** Please download, test and vote by Wednesday, > > September > > > > > 21, > > > > > > > > 12pm PT > > > > > > > > > > > > > > > > > > > > > > > > Kafka's KEYS file containing PGP keys we use to sign > > the > > > > > > release: > > > > > > > > > > > > https://kafka.apache.org/KEYS > > > > > > > > > > > > > > > > > > > > > > > > * Release artifacts to be voted upon (source and > > binary): > > > > > > > > > > > > https://home.apache.org/~satishd/kafka-3.6.0-rc0/ > > > > > > > > > > > > > > > > > > > > > > > > * Maven artifacts to be voted upon: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/kafka/ > > > > > > > > > > > > > > > > > > > > > > > > * Javadoc: > > > > > > > > > > > > > > https://home.apache.org/~satishd/kafka-3.6.0-rc0/javadoc/ > > > > > > > > > > > > > > > > > > > > > > > > * Tag to be voted upon (off 3.6 branch) is the 3.6.0 > > tag: > > > > > > > > > > > > https://github.com/apache/kafka/releases/tag/3.6.0-rc0 > > > > > > > > > > > > > > > > > > > > > > > > * Documentation: > > > > > > > > > > > > https://kafka.apache.org/36/documentation.html > > > > > > > > > > > > > > > > > > > > > > > > * Protocol: > > > > > > > > > > > > https://kafka.apache.org/36/protocol.html > > > > > > > > > > > > > > > > > > > > > > > > * Successful Jenkins builds for the 3.6 branch: > > > > > > > > > > > > There are a few runs of unit/integration tests. You > > can see > > > > > the > > > > > > > > latest at > > > > > > > > > > > > > > https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.6/. > > > > > We > > > > > > will > > > > > > > > > > > > continue > > > > > > > > > > > > running a few more iterations. > > > > > > > > > > > > System tests: > > > > > > > > > > > > We will send an update once we have the results. > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Satish. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > David Arthur > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > [image: Aiven] <https://www.aiven.io> > > > > > > > > > > > > > > > > > > > > *Josep Prat* > > > > > > > > > > Open Source Engineering Director, *Aiven* > > > > > > > > > > josep.p...@aiven.io | +491715557497 > > > > > > > > > > aiven.io <https://www.aiven.io> | < > > > > > > > > https://www.facebook.com/aivencloud> > > > > > > > > > > <https://www.linkedin.com/company/aiven/> < > > > > > > > > https://twitter.com/aiven_io> > > > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > > > Alexanderufer 3-7, 10117 Berlin > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > > > > > > > > > > > > > > > -- > -David
