----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23962/#review48820 -----------------------------------------------------------
Thanks for the patch. A couple of comments below. core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala <https://reviews.apache.org/r/23962/#comment85555> Both methods can be private. core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala <https://reviews.apache.org/r/23962/#comment85556> Let's add an explanation on why we need to do this check in the comment. How about the following? We can get here during the initial startup and the handleDeleted ZK callback. Because of the potential race condition, it's possible that the controller has already been elected when we get here. This check will prevent the following createEphemeralPath method to get into an infinite loop if this broker is already the controller. - Jun Rao On July 26, 2014, 9:48 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23962/ > ----------------------------------------------------------- > > (Updated July 26, 2014, 9:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1451 > https://issues.apache.org/jira/browse/KAFKA-1451 > > > Repository: kafka > > > Description > ------- > > controller existence check added in election process of ZookeeperLeaderElector > > > Diffs > ----- > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala > e5b6ff1e2544b043007cf16a6b9dd4451c839e63 > > Diff: https://reviews.apache.org/r/23962/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
