> On July 29, 2014, 4:08 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala, lines 71-72 > > <https://reviews.apache.org/r/23962/diff/3/?file=643587#file643587line71> > > > > I think we need to first update leaderId here based on the value > > returned from getControllerID(), and then check if the controller exists. > > Otherwise, if the another broker is the controller, this broker's leaderId > > won't be updated correctly.
Initially I also thought of updating leaderId field. But we are using leaderId field in amILeader method only. I thought its OK to not to update leaderId field. Anyhow.. i will upload a new patch with correct leaderId update. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23962/#review48965 ----------------------------------------------------------- On July 29, 2014, 4:45 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23962/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 4:45 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1451 > https://issues.apache.org/jira/browse/KAFKA-1451 > > > Repository: kafka > > > Description > ------- > > Addresing Jun's Comments > > > Diffs > ----- > > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala > e5b6ff1e2544b043007cf16a6b9dd4451c839e63 > > Diff: https://reviews.apache.org/r/23962/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >