+0 Alieh, Matthias, Andrew--I know this isn't what you were hoping for, and I want to acknowledge the significant time and effort you've put into this KIP. I do believe it solves a real problem for Kafka Streams, but I don't believe the solution as presented is worth the fine print and potential footguns that it would come with for other users of the producer API. I also believe that the way that the design is predicated on producer internals makes these issues virtually impossible to overcome. If an internal configuration property is an option, I think that would be a reasonable compromise. And if not, I still don't dislike this strongly enough to actively try to block it with a -1 vote; if there are other committers who disagree with my assessment and believe that this design makes the right tradeoffs, then I believe this KIP deserves to pass.
I'll continue to monitor the discussion thread in case there's an opportunity to change my mind. Best, Chris On Fri, Jun 28, 2024 at 6:32 PM Matthias J. Sax <mj...@apache.org> wrote: > Thanks for the KIP Alieh! > > +1 (binding) > > > -Matthias > > On 6/26/24 5:29 AM, Andrew Schofield wrote: > > Hi Alieh, > > Thanks for the KIP. I think we’ve settled on a good solution. > > > > +1 (non-binding) > > > > Thanks, > > Andrew > > > >> On 25 Jun 2024, at 13:17, Alieh Saeedi <asae...@confluent.io.INVALID> > wrote: > >> > >> Hi all, > >> > >> I would like to open voting for KIP-1059: Enable the Producer flush() > >> method to clear the latest send() error > >> < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1059%3A+Enable+the+Producer+flush%28%29+method+to+clear+the+latest+send%28%29+error > > > >> . > >> > >> Cheers, > >> Alieh > > >
