----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58185 -----------------------------------------------------------
Ship it! Looks good - can you upload an updated RB incorporating the minor comments? core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment99129> exited - Joel Koshy On Oct. 23, 2014, 11:20 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26994/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 11:20 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1719 > https://issues.apache.org/jira/browse/KAFKA-1719 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comments. > > > Addressed Neha and Guzhang's comments. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > b8698ee1469c8fbc92ccc176d916eb3e28b87867 > > Diff: https://reviews.apache.org/r/26994/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
