----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ -----------------------------------------------------------
(Updated Oct. 24, 2014, 7:56 a.m.) Review request for kafka. Bugs: KAFKA-1719 https://issues.apache.org/jira/browse/KAFKA-1719 Repository: kafka Description (updated) ------- Addressed Guozhang's comments. Addressed Neha and Guzhang's comments. Incorporated Joel and Neha's comments. Incorporated Joel and Neha's comments. Also fixed a potential race where cleanShutdown could execute multiple times if several threads exit abnormally at same time. Diffs (updated) ----- core/src/main/scala/kafka/tools/MirrorMaker.scala b8698ee1469c8fbc92ccc176d916eb3e28b87867 Diff: https://reviews.apache.org/r/26994/diff/ Testing ------- Thanks, Jiangjie Qin