[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209055#comment-14209055
]
Joel Koshy commented on KAFKA-1481:
-----------------------------------
(1) and (4) seem equivalent (i.e., AllTopics vs Aggregate) - or are you saying
that (4) will be AllTopics or AllBrokers as appropriate?
I'm +0 on (5) for the reason I stated above. i.e., it is odd to see "true" when
browsing mbeans
I'm +0 on (6) as well as "topics=aggregate" is a bit odd. The field name
suggests it is a list of topics but it is more like a boolean. Between this and
(5) I prefer (5).
(3) seems reasonable to me although it is not as clear as having an explicit
aggregate term in the type. However, I think (1), (2) and (3) do make it clear
enough what is being aggregated: i.e., bytes-out-per-sec aggregated on topic. I
actually think "Broker" should not be there since this is a broker-side mbean
already. i.e., if we had kafka.server:type=TopicMetrics,name=BytesOutPerSec
(wouldn't it be clear that the dimension of aggregation is across topics?)
i.e., I think we can just make the dimension clear from the typename.
Likewise, it should be clear (for consumers) that
FetchRequestAndResponseMetrics is really a broker-level aggregation.
> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
> Key: KAFKA-1481
> URL: https://issues.apache.org/jira/browse/KAFKA-1481
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Reporter: Otis Gospodnetic
> Priority: Critical
> Labels: patch
> Fix For: 0.8.3
>
> Attachments: KAFKA-1481_2014-06-06_13-06-35.patch,
> KAFKA-1481_2014-10-13_18-23-35.patch, KAFKA-1481_2014-10-14_21-53-35.patch,
> KAFKA-1481_2014-10-15_10-23-35.patch, KAFKA-1481_2014-10-20_23-14-35.patch,
> KAFKA-1481_2014-10-21_09-14-35.patch, KAFKA-1481_2014-10-30_21-35-43.patch,
> KAFKA-1481_2014-10-31_14-35-43.patch,
> KAFKA-1481_2014-11-03_16-39-41_doc.patch,
> KAFKA-1481_2014-11-03_17-02-23.patch,
> KAFKA-1481_2014-11-10_20-39-41_doc.patch,
> KAFKA-1481_2014-11-10_21-02-23.patch,
> KAFKA-1481_IDEA_IDE_2014-10-14_21-53-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-15_10-23-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_20-14-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_23-14-35.patch, alternateLayout1.png,
> alternateLayout2.png, diff-for-alternate-layout1.patch,
> diff-for-alternate-layout2.patch, originalLayout.png
>
>
> MBeans should not use dashes or underscores as separators because these
> characters are allowed in hostnames, topics, group and consumer IDs, etc.,
> and these are embedded in MBeans names making it impossible to parse out
> individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict.
> This looks like a major blocker because it means nobody can write Kafka 0.8.x
> monitoring tools unless they are doing it for themselves AND do not use
> dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
