[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212536#comment-14212536
]
Jun Rao commented on KAFKA-1481:
--------------------------------
Thanks for the patch. Appreciate your persistence. A few comments below.
80. AppInfo.registerInfo()
80.1 On the server side, this needs to be called in
KafkaServerStartable.startup(). Some users will start up a Kafka broker using
KafkaServerStartable in a container and not from the command line.
80.2 On the client side, if there are multiple instances of clients running in
the same jvm, registerInfo() will be called multiple times. It would be good if
we make sure registerInfo() only register the mbean once no matter how many
times it's called. We can maintain an isRegistered flag internally and only
register the mbean if the flag is not set. We can also make this a synchronized
method.
80.3 There is no need to call registerInfo() in ConsoleConsumer and
ProducerPerformance since the mbean will be registered by the consumer/producer
client.
80.4 We will need to add the same version mbean in the new java client. We
don't need to do that in this jira. Could you file a separate jira to track
that?
81. KafkaServer: remove unused import AppInfo
82. TestUtils: Could you fix the indentation in the following?
def sendMessagesToPartition(configs: Seq[KafkaConfig],
topic: String,
partition: Int,
numMessages: Int,
compression: CompressionCodec =
NoCompressionCodec): List[String] = {
83. As I was reviewing KAFKA-1684, I realized that in the future, a broker may
have multiple ports: plain text, SSL, SASL, etc. In this patch, the
broker-specific mbeans have the tag of brokerHost and brokerPort. This is going
to be inconvenient once the broker has more than one port. I was thinking it's
simpler if we just add the brokerId tag or both the brokerId and the brokerHost
tag. What do you think?
> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
> Key: KAFKA-1481
> URL: https://issues.apache.org/jira/browse/KAFKA-1481
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Reporter: Otis Gospodnetic
> Priority: Critical
> Labels: patch
> Fix For: 0.8.3
>
> Attachments: KAFKA-1481_2014-06-06_13-06-35.patch,
> KAFKA-1481_2014-10-13_18-23-35.patch, KAFKA-1481_2014-10-14_21-53-35.patch,
> KAFKA-1481_2014-10-15_10-23-35.patch, KAFKA-1481_2014-10-20_23-14-35.patch,
> KAFKA-1481_2014-10-21_09-14-35.patch, KAFKA-1481_2014-10-30_21-35-43.patch,
> KAFKA-1481_2014-10-31_14-35-43.patch,
> KAFKA-1481_2014-11-03_16-39-41_doc.patch,
> KAFKA-1481_2014-11-03_17-02-23.patch,
> KAFKA-1481_2014-11-10_20-39-41_doc.patch,
> KAFKA-1481_2014-11-10_21-02-23.patch, KAFKA-1481_2014-11-14_16-33-03.patch,
> KAFKA-1481_2014-11-14_16-39-41_doc.patch,
> KAFKA-1481_IDEA_IDE_2014-10-14_21-53-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-15_10-23-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_20-14-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_23-14-35.patch, alternateLayout1.png,
> alternateLayout2.png, diff-for-alternate-layout1.patch,
> diff-for-alternate-layout2.patch, originalLayout.png
>
>
> MBeans should not use dashes or underscores as separators because these
> characters are allowed in hostnames, topics, group and consumer IDs, etc.,
> and these are embedded in MBeans names making it impossible to parse out
> individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict.
> This looks like a major blocker because it means nobody can write Kafka 0.8.x
> monitoring tools unless they are doing it for themselves AND do not use
> dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
