----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29523/#review66544 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java <https://reviews.apache.org/r/29523/#comment110116> Couple of things: 1. The javadoc example is now out of date I think. 2. We don't really document what the group and tags concept actually mean. What should I put in there? 3. Should group/tags be optional? It doesn't look like we have any methods that don't require them. clients/src/main/java/org/apache/kafka/common/network/Selector.java <https://reviews.apache.org/r/29523/#comment110111> Selector is part of the network package which just does low-level network stuff. It can't reference clientId which is a higher-level concept. If you want to pass in a map of tags that might work. clients/src/main/java/org/apache/kafka/common/network/Selector.java <https://reviews.apache.org/r/29523/#comment110113> This is hard-coding ProducerMetrics in generic Selector code that is also used in the consumer and will be used elsewhere. clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java <https://reviews.apache.org/r/29523/#comment110114> BufferPool doesn't know about clientId - Jay Kreps On Jan. 1, 2015, 1:54 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29523/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2015, 1:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1723 > https://issues.apache.org/jira/browse/KAFKA-1723 > > > Repository: kafka > > > Description > ------- > > Standard JMX MBean Naming is implemented > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > d859fc588a276eb36bcfd621ae6d7978ad0decdd > > clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java > aa91e1444a49c55870b9a7a32086fa2b04471fba > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > c15485d1af304ef53691d478f113f332fe67af77 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 84a7a07269c51ccc22ebb4ff9797292d07ba778e > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java > 3c312011a7ff7e79c277a89048e7e62ebd6078db > clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java > a7458b50cb16fbb2b31b857d5b359e65258bbf08 > clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java > 49be4019ac03835701c49646920766228ac7ffe9 > clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java > 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 4dd2cdf773f7eb01a93d7f994383088960303dfc > clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java > fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java > 2c9932401d573549c40f16fda8c4e3e11309cb85 > clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java > ef2ca65cabe97b909f17b62027a1bb06827e88fe > clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java > 2f43c49450e1a3d671bd17417dc42941f1858750 > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 > clients/src/test/java/org/apache/kafka/test/MetricsBench.java > 9d98c1148255455fd801043b59b98fed9d0b76b3 > > Diff: https://reviews.apache.org/r/29523/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
