----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29523/#review67309 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java <https://reviews.apache.org/r/29523/#comment111305> Since this is a public class can you add some javadoc that describes the basic data model and gives an example to help explain it? Basically someone who encounters this class from the Producer or Consumer interface should be able to figure out how to interpret things like group and tag. - Jay Kreps On Jan. 8, 2015, 4:34 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29523/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 4:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1723 > https://issues.apache.org/jira/browse/KAFKA-1723 > > > Repository: kafka > > > Description > ------- > > Standard JMX MBean Naming is implemented;Addresing Jay's comments > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java > 1bce50185273dbdbc131fbc9c7f5f3e9c346517a > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 7f8a41c4bf437711685a8271a4d3c83a176dd957 > clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java > 8cab16c0a0bdb671fea1fc2fc2694247f66cc971 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 3053f2745c8e5f6e3b75826d3749656f150878db > clients/src/main/java/org/apache/kafka/clients/producer/Producer.java > 5baa6062bd9ba8a7d38058856ed2d831fae491f0 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java > aa91e1444a49c55870b9a7a32086fa2b04471fba > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > c15485d1af304ef53691d478f113f332fe67af77 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 84a7a07269c51ccc22ebb4ff9797292d07ba778e > clients/src/main/java/org/apache/kafka/common/Metric.java > b023e8e7c486adf21ed9a554085ab8ad7f3ee038 > clients/src/main/java/org/apache/kafka/common/metrics/CompoundStat.java > 29185a6a90d0035d650c7e56ce612a0878cb115c > clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java > 3c312011a7ff7e79c277a89048e7e62ebd6078db > clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java > a7458b50cb16fbb2b31b857d5b359e65258bbf08 > clients/src/main/java/org/apache/kafka/common/metrics/MetricName.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java > 49be4019ac03835701c49646920766228ac7ffe9 > clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java > 25c1faf2887ea02708c1f5b5f822f5299ed86bd6 > clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentile.java > 7365ceb39072a6a1ecf533f5a20830ed1f2cfc72 > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java > c70d577ada8c099533d4f4ed2e86d37e0a6e6676 > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 4dd2cdf773f7eb01a93d7f994383088960303dfc > clients/src/test/java/org/apache/kafka/clients/producer/BufferPoolTest.java > fe3c13f319d48b89a4f26b6d78c2c3e31cc50d7e > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java > 2c9932401d573549c40f16fda8c4e3e11309cb85 > clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java > ef2ca65cabe97b909f17b62027a1bb06827e88fe > clients/src/test/java/org/apache/kafka/common/metrics/JmxReporterTest.java > 2f43c49450e1a3d671bd17417dc42941f1858750 > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > 19bea0f1fa1ebf15d86623015ec909b0155e4bd3 > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 > clients/src/test/java/org/apache/kafka/test/MetricsBench.java > 9d98c1148255455fd801043b59b98fed9d0b76b3 > > Diff: https://reviews.apache.org/r/29523/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
